Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 363343004: DevTools: Unify main thread name across vanilla and tracing timeline modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.TracingModel} tracingModel 7 * @param {!WebInspector.TracingModel} tracingModel
8 * @param {!WebInspector.TimelineModel.Filter} recordFilter 8 * @param {!WebInspector.TimelineModel.Filter} recordFilter
9 * @extends {WebInspector.TimelineModel} 9 * @extends {WebInspector.TimelineModel}
10 */ 10 */
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
536 536
537 /** 537 /**
538 * @return {number} 538 * @return {number}
539 */ 539 */
540 startTime: function() 540 startTime: function()
541 { 541 {
542 return this._event.startTime; 542 return this._event.startTime;
543 }, 543 },
544 544
545 /** 545 /**
546 * @return {string|undefined} 546 * @return {string}
547 */ 547 */
548 thread: function() 548 thread: function()
549 { 549 {
550 return "CPU"; 550 // FIXME: Should return the actual thread name.
551 return WebInspector.TimelineModel.MainThreadName;
551 }, 552 },
552 553
553 /** 554 /**
554 * @return {number} 555 * @return {number}
555 */ 556 */
556 endTime: function() 557 endTime: function()
557 { 558 {
558 return this._event.endTime || this._event.startTime; 559 return this._event.endTime || this._event.startTime;
559 }, 560 },
560 561
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 * @param {!WebInspector.TracingTimelineModel.TraceEventRecord} child 653 * @param {!WebInspector.TracingTimelineModel.TraceEventRecord} child
653 */ 654 */
654 _addChild: function(child) 655 _addChild: function(child)
655 { 656 {
656 this._children.push(child); 657 this._children.push(child);
657 child.parent = this; 658 child.parent = this;
658 }, 659 },
659 660
660 661
661 } 662 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698