Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363323007: Revert of Componentize TemplateURLService (Closed)

Created:
6 years, 5 months ago by hashimoto
Modified:
6 years, 5 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, zea+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, melevin+watch_chromium.org, benquan, dominich, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-options_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dyu1, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, estade+watch_chromium.org, Jered, maniscalco+watch_chromium.org, tfarina, donnd+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jun Mukai
Project:
chromium
Visibility:
Public.

Description

Revert of Componentize TemplateURLService (https://codereview.chromium.org/367023002/) Reason for revert: Failed on android_aosp: http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/12338 Original issue's description: > Componentize TemplateURLService > > Move TemplateURLService, SearchHostToURLsMap, util.cc from chrome/browser/search_engines to components/search_engines > Move KeywordTable and KeywordWeDataService from chrome/browser/webdata to components/search_engines > Fix DEPS, OWNERS and gyp. > Replace HistoryDatabase in keyword_table.cc with URLDatabase. > > BUG=386367 > TEST=build and checkdeps > R=blundell@chromium.org, jochen@chromium.org, pkasting@chromium.org > TBR=jochen@chromium.org for include fix, erikwright@chromium.org as an owner of sql, atwilson@chromium.org as an owner of sync > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281350 TBR=pkasting@chromium.org,blundell@chromium.org,jochen@chromium.org,erikwright@chromium.org,atwilson@chromium.org NOTREECHECKS=true NOTRY=true BUG=386367 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5109 lines, -5109 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/search_engines/TemplateUrlService.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/logo_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/external_process_importer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/profile_writer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_unittest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_unittest_base.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search/search_terms_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/DEPS View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/search_engines/chrome_template_url_service_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/chrome_template_url_service_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/search_engines/search_host_to_urls_map.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/search_engines/search_host_to_urls_map.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/search_host_to_urls_map_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_scraper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/search_engines/template_url_service.h View 1 chunk +762 lines, -0 lines 0 comments Download
A chrome/browser/search_engines/template_url_service.cc View 1 chunk +2372 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/search_engines/template_url_service_client.h View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/search_engines/template_url_service_observer.h View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/search_engines/util.h View 1 chunk +136 lines, -0 lines 0 comments Download
A chrome/browser/search_engines/util.cc View 1 chunk +389 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/search_engines_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_search_engines_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_search_engines_sync_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_extended_interactive_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/instant_test_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/edit_search_engine_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/tab_contents/core_tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/uma_browsing_activity_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/test_with_browser_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/keyword_hint_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/selected_keyword_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/webdata/keyword_table.h View 1 chunk +185 lines, -0 lines 0 comments Download
A chrome/browser/webdata/keyword_table.cc View 1 chunk +647 lines, -0 lines 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/webdata/keyword_web_data_service.h View 1 chunk +110 lines, -0 lines 0 comments Download
A chrome/browser/webdata/keyword_web_data_service.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/search_engines.gypi View 3 chunks +0 lines, -18 lines 0 comments Download
M components/search_engines/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/search_engines/keyword_table.h View 1 chunk +0 lines, -185 lines 0 comments Download
D components/search_engines/keyword_table.cc View 1 chunk +0 lines, -647 lines 0 comments Download
D components/search_engines/keyword_web_data_service.h View 1 chunk +0 lines, -110 lines 0 comments Download
D components/search_engines/keyword_web_data_service.cc View 1 chunk +0 lines, -149 lines 0 comments Download
D components/search_engines/search_host_to_urls_map.h View 1 chunk +0 lines, -66 lines 0 comments Download
D components/search_engines/search_host_to_urls_map.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D components/search_engines/template_url_service.h View 1 chunk +0 lines, -762 lines 0 comments Download
D components/search_engines/template_url_service.cc View 1 chunk +0 lines, -2372 lines 0 comments Download
D components/search_engines/template_url_service_client.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/search_engines/template_url_service_observer.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/search_engines/util.h View 1 chunk +0 lines, -136 lines 0 comments Download
D components/search_engines/util.cc View 1 chunk +0 lines, -389 lines 0 comments Download
M components/webdata/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
Created Revert of Componentize TemplateURLService
6 years, 5 months ago (2014-07-04 04:58:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/363323007/1
6 years, 5 months ago (2014-07-04 04:58:49 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 05:00:20 UTC) #3
Message was sent while issue was closed. 
Change committed as 281362

Powered by Google App Engine
This is Rietveld 408576698