Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 363313002: Remove unnecessary check in RegExpExecStub. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove unnecessary check in RegExpExecStub. R=ulan@chromium.org BUG=v8:592 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +3 lines, -8 lines 0 comments Download
A test/mjsunit/regexp-stack-overflow.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-03 11:50:32 UTC) #1
ulan
lgtm
6 years, 5 months ago (2014-07-03 13:19:32 UTC) #2
Yang
6 years, 5 months ago (2014-07-03 14:03:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698