Issue 363303002: Add an API to pump the message loop to libplatform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363303002: Add an API to pump the message loop to libplatform (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 5 months ago

Reviewers:
marja

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add an API to pump the message loop to libplatform BUG=none LOG=n R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22187

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -6 lines)			Patch
M	include/libplatform/libplatform.h	View	1 chunk	+11 lines, -0 lines	1 comment	Download
M	src/libplatform/default-platform.h	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	src/libplatform/default-platform.cc	View	4 chunks	+33 lines, -3 lines	0 comments	Download
M	test/cctest/cctest.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/cctest/test-libplatform-default-platform.cc	View	1 chunk	+31 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

lgtm https://codereview.chromium.org/363303002/diff/1/include/libplatform/libplatform.h File include/libplatform/libplatform.h (right): https://codereview.chromium.org/363303002/diff/1/include/libplatform/libplatform.h#newcode29 include/libplatform/libplatform.h:29: * not block if not task is pending. ...

6 years, 5 months ago (2014-07-03 09:26:35 UTC) #2

jochen (gone - plz use gerrit)

6 years, 5 months ago (2014-07-03 09:33:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22187 (presubmit successful).

Expand Messages | Collapse Messages