Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2454)

Unified Diff: chrome/renderer/chrome_render_view_observer.h

Issue 363293005: Remove page id from "page capture". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert to patch set 1 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/chrome_render_view_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_view_observer.h
diff --git a/chrome/renderer/chrome_render_view_observer.h b/chrome/renderer/chrome_render_view_observer.h
index e225bde7b575ef5237d9485a24d30ce622360a7d..35df8716c838d4b0ad0fbb443f6ae06970897517 100644
--- a/chrome/renderer/chrome_render_view_observer.h
+++ b/chrome/renderer/chrome_render_view_observer.h
@@ -71,13 +71,12 @@ class ChromeRenderViewObserver : public content::RenderViewObserver {
void OnSetClientSidePhishingDetection(bool enable_phishing_detection);
void OnSetWindowFeatures(const blink::WebWindowFeatures& window_features);
- void CapturePageInfoLater(int page_id,
- bool preliminary_capture,
+ void CapturePageInfoLater(bool preliminary_capture,
base::TimeDelta delay);
// Captures the thumbnail and text contents for indexing for the given load
// ID. Kicks off analysis of the captured text.
- void CapturePageInfo(int page_id, bool preliminary_capture);
+ void CapturePageInfo(bool preliminary_capture);
// Retrieves the text from the given frame contents, the page text up to the
// maximum amount kMaxIndexChars will be placed into the given buffer.
@@ -99,14 +98,6 @@ class ChromeRenderViewObserver : public content::RenderViewObserver {
TranslateHelper* translate_helper_;
safe_browsing::PhishingClassifierDelegate* phishing_classifier_;
- // Page_id from the last page we indexed. This prevents us from indexing the
- // same page twice in a row.
- int32 last_indexed_page_id_;
- // The toplevel URL that was last indexed. This is used together with the
- // page id to decide whether to reindex in certain cases like history
- // replacement.
- GURL last_indexed_url_;
-
// A color page overlay when visually de-emaphasized.
scoped_ptr<WebViewColorOverlay> dimmed_color_overlay_;
« no previous file with comments | « no previous file | chrome/renderer/chrome_render_view_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698