Abstract base 'ExtensionView' to Fix DEPS violation in extension_view_host.h

chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/browser/ui/cocoa/extensions/extension_view_mac.h"
+
 #import <Cocoa/Cocoa.h>
 
-#include "chrome/browser/ui/cocoa/extensions/extension_view_mac.h"
-
+#include "chrome/browser/extensions/extension_view_host.h"
+#import "chrome/browser/ui/cocoa/chrome_event_processing_window.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/common/view_type.h"
 
 // The minimum/maximum dimensions of the popup.
 const CGFloat ExtensionViewMac::kMinWidth = 25.0;
 const CGFloat ExtensionViewMac::kMinHeight = 25.0;
 const CGFloat ExtensionViewMac::kMaxWidth = 800.0;
 const CGFloat ExtensionViewMac::kMaxHeight = 600.0;
 
 ExtensionViewMac::ExtensionViewMac(extensions::ExtensionHost* extension_host,
                                    Browser* browser)
     : browser_(browser),
       extension_host_(extension_host),
       container_(NULL) {
   DCHECK(extension_host_);
-  [native_view() setHidden:YES];
+  [GetNativeView() setHidden:YES];
 }
 
 ExtensionViewMac::~ExtensionViewMac() {
 }
 
+content::RenderViewHost* ExtensionViewMac::render_view_host() const {
+  return extension_host_->render_view_host();
+}
+
+void ExtensionViewMac::WindowFrameChanged() {
+  if (render_view_host()->GetView())
+    render_view_host()->GetView()->WindowFrameChanged();
+}
+
+void ExtensionViewMac::CreateWidgetHostView() {
+  extension_host_->CreateRenderViewSoon();
+}
+
+void ExtensionViewMac::ShowIfCompletelyLoaded() {
+  // We wait to show the ExtensionView until it has loaded, and the view has
+  // actually been created. These can happen in different orders.
+  if (extension_host_->did_stop_loading()) {
+    [GetNativeView() setHidden:NO];
+    if (container_)
+      container_->OnExtensionViewDidShow(this);
+  }
+}
+
 void ExtensionViewMac::Init() {
   CreateWidgetHostView();
 }
 
-gfx::NativeView ExtensionViewMac::native_view() {
+Browser* ExtensionViewMac::GetBrowser() {
+  return browser_;
+}
+
+gfx::NativeView ExtensionViewMac::GetNativeView() {
   return extension_host_->host_contents()->GetNativeView();
 }
 
-content::RenderViewHost* ExtensionViewMac::render_view_host() const {
-  return extension_host_->render_view_host();
-}
-
-void ExtensionViewMac::DidStopLoading() {
-  ShowIfCompletelyLoaded();
-}
-
 void ExtensionViewMac::ResizeDueToAutoResize(const gfx::Size& new_size) {
   if (container_)
     container_->OnExtensionSizeChanged(this, new_size);
 }
 
 void ExtensionViewMac::RenderViewCreated() {
   extensions::ViewType host_type = extension_host_->extension_host_type();
   if (host_type == extensions::VIEW_TYPE_EXTENSION_POPUP) {
     gfx::Size min_size(ExtensionViewMac::kMinWidth,
                        ExtensionViewMac::kMinHeight);
     gfx::Size max_size(ExtensionViewMac::kMaxWidth,
                        ExtensionViewMac::kMaxHeight);
     render_view_host()->EnableAutoResize(min_size, max_size);
   }
 }
 
-void ExtensionViewMac::WindowFrameChanged() {
-  if (render_view_host()->GetView())
-    render_view_host()->GetView()->WindowFrameChanged();
+void ExtensionViewMac::HandleKeyboardEvent(
+    content::WebContents* source,
+    const content::NativeWebKeyboardEvent& event) {
+  if (event.skip_in_browser ||
+      event.type == content::NativeWebKeyboardEvent::Char ||
+      extension_host_->extension_host_type() !=
+          extensions::VIEW_TYPE_EXTENSION_POPUP) {
+    return;
+  }

[Finnur, 2014/07/03 14:27:05]

nit: You don't need braces if the if clause is single line (the style rule does
not apply to multi-line condititionals.

[tapted, 2014/07/04 00:08:03]

Done.

+
+  ChromeEventProcessingWindow* event_window =
+      static_cast<ChromeEventProcessingWindow*>([GetNativeView() window]);
+  DCHECK([event_window isKindOfClass:[ChromeEventProcessingWindow class]]);
+  [event_window redispatchKeyEvent:event.os_event];
 }
 
-void ExtensionViewMac::CreateWidgetHostView() {
-  extension_host_->CreateRenderViewSoon();
+void ExtensionViewMac::DidStopLoading() {
+  ShowIfCompletelyLoaded();
 }
 
-void ExtensionViewMac::ShowIfCompletelyLoaded() {
-  // We wait to show the ExtensionView until it has loaded, and the view has
-  // actually been created. These can happen in different orders.
-  if (extension_host_->did_stop_loading()) {
-    [native_view() setHidden:NO];
-    if (container_)
-      container_->OnExtensionViewDidShow(this);
-  }
+namespace extensions {
+
+// static
+scoped_ptr<ExtensionView> ExtensionViewHost::CreateExtensionView(
+    ExtensionViewHost* host,
+    Browser* browser) {
+  scoped_ptr<ExtensionViewMac> view(new ExtensionViewMac(host, browser));
+  return view.PassAs<ExtensionView>();
 }
+
+}  // namespace extensions