Abstract base 'ExtensionView' to Fix DEPS violation in extension_view_host.h

chrome/browser/ui/views/extensions/extension_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_view_views.h"
 
+#include "chrome/browser/extensions/extension_view_host.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/views/extensions/extension_popup.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/common/view_type.h"
 #include "ui/events/event.h"
 #include "ui/views/widget/widget.h"
 
@@ skipping 47 matching lines @@
   return gfx::kNullCursor;
 }
 
 void ExtensionViewViews::ViewHierarchyChanged(
     const ViewHierarchyChangedDetails& details) {
   NativeViewHost::ViewHierarchyChanged(details);
   if (details.is_add && GetWidget() && !initialized_)
     CreateWidgetHostView();
 }
 
-void ExtensionViewViews::DidStopLoading() {
-  ShowIfCompletelyLoaded();
-}
-
 void ExtensionViewViews::SetIsClipped(bool is_clipped) {
   if (is_clipped_ != is_clipped) {
     is_clipped_ = is_clipped;
     if (visible())
       ShowIfCompletelyLoaded();
   }
 }
 
+void ExtensionViewViews::Init() {
+  // Initialization continues in ViewHierarchyChanged().
+}
+
+Browser* ExtensionViewViews::GetBrowser() {
+  return browser_;
+}
+
+gfx::NativeView ExtensionViewViews::GetNativeView() {
+  return native_view();
+}
+
 void ExtensionViewViews::ResizeDueToAutoResize(const gfx::Size& new_size) {
   // Don't actually do anything with this information until we have been shown.
   // Size changes will not be honored by lower layers while we are hidden.
   if (!visible()) {
     pending_preferred_size_ = new_size;
     return;
   }
 
   if (new_size != GetPreferredSize())
     SetPreferredSize(new_size);
 }
 
 void ExtensionViewViews::RenderViewCreated() {
   extensions::ViewType host_type = host_->extension_host_type();
   if (host_type == extensions::VIEW_TYPE_EXTENSION_POPUP) {
     render_view_host()->EnableAutoResize(
         gfx::Size(ExtensionPopup::kMinWidth, ExtensionPopup::kMinHeight),
         gfx::Size(ExtensionPopup::kMaxWidth, ExtensionPopup::kMaxHeight));
   }
 }
 
 void ExtensionViewViews::HandleKeyboardEvent(
+    content::WebContents* source,
     const content::NativeWebKeyboardEvent& event) {
+  if (browser_) {
+    // Handle lower priority browser shortcuts such as Ctrl-f.
+    browser_->HandleKeyboardEvent(source, event);
+    return;
+  }
+
   unhandled_keyboard_event_handler_.HandleKeyboardEvent(event,
                                                         GetFocusManager());
 }
 
+void ExtensionViewViews::DidStopLoading() {
+  ShowIfCompletelyLoaded();
+}
+
 bool ExtensionViewViews::SkipDefaultKeyEventProcessing(const ui::KeyEvent& e) {
   // Let the tab key event be processed by the renderer (instead of moving the
   // focus to the next focusable view). Also handle Backspace, since otherwise
   // (on Windows at least), pressing Backspace, when focus is on a text field
   // within the ExtensionViewViews, will navigate the page back instead of
   // erasing a character.
   return (e.key_code() == ui::VKEY_TAB || e.key_code() == ui::VKEY_BACK);
 }
 
 void ExtensionViewViews::OnBoundsChanged(const gfx::Rect& previous_bounds) {
@@ skipping 33 matching lines @@
   }
 }
 
 void ExtensionViewViews::CleanUp() {
   if (!initialized_)
     return;
   if (native_view())
     Detach();
   initialized_ = false;
 }
+
+namespace extensions {
+
+// static
+scoped_ptr<ExtensionView> ExtensionViewHost::CreateExtensionView(
+    ExtensionViewHost* host,
+    Browser* browser) {
+  scoped_ptr<ExtensionViewViews> view(new ExtensionViewViews(host, browser));
+  // We own |view_|, so don't auto delete when it's removed from the view
+  // hierarchy.
+  view->set_owned_by_client();
+  return view.PassAs<ExtensionView>();
+}
+
+}  // namespace extensions