Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA

Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA
crash rate decreases.

BUG=391165
R=rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281320

[ramant (doing other things), 2014-07-03 03:31:19]

PTAL.

thanks
raman

[Robert Sesek, 2014-07-03 03:37:34]

lgtm

rsesek / @chromium.org


On Wed, Jul 2, 2014 at 11:31 PM, <rtenneti@chromium.org> wrote:

> Reviewers: rsesek,
>
> Message:
> PTAL.
>
> thanks
> raman
>
> Description:
> Breakpad for windows - disable DumpProcessWithoutCrash to see if UMA
> crash rate decreases.
>
> BUG=391165
> R=rsesek@chromium.org
>
> Please review this at https://codereview.chromium.org/363203002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+3, -1 lines):
>   M components/breakpad/app/breakpad_win.cc
>
>
> Index: components/breakpad/app/breakpad_win.cc
> diff --git a/components/breakpad/app/breakpad_win.cc
> b/components/breakpad/app/breakpad_win.cc
> index 1f6a3c49a93b5f4fc3ab90331d8bba0c800c7832..
> 2f3750dfd6f3eb2bba5810022409b8d9f0d2e322 100644
> --- a/components/breakpad/app/breakpad_win.cc
> +++ b/components/breakpad/app/breakpad_win.cc
> @@ -573,7 +573,9 @@ void InitCrashReporter(const std::string&
> process_type_switch) {
>        google_breakpad::ExceptionHandler::HANDLER_NONE,
>        dump_type, pipe_name.c_str(), custom_info);
>
> -  base::debug::SetDumpWithoutCrashingFunction(&DumpProcessWithoutCrash);
> +  // TODO(rtenneti): http://crbug.com/391165. Undo this change after
> getting
> +  // data. Disabled DumpProcessWithoutCrash to see if UMA crash rate
> decreases.
> +  // base::debug::SetDumpWithoutCrashingFunction
> (&DumpProcessWithoutCrash);
>
>    if (g_breakpad->IsOutOfProcess()) {
>      // Tells breakpad to handle breakpoint and single step exceptions.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Robert Sesek, 2014-07-03 03:38:12]

lgtm

[ramant (doing other things), 2014-07-03 18:19:48]

The CQ bit was checked by rtenneti@chromium.org

[commit-bot: I haz the power, 2014-07-03 18:20:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rtenneti@chromium.org/363203002/1

[commit-bot: I haz the power, 2014-07-03 21:00:34]

Change committed as 281320

[ramant (doing other things), 2014-07-15 22:40:58]

A revert of this CL has been created in
https://codereview.chromium.org/397593005/ by rtenneti@chromium.org.

The reason for reverting is: This change didn't reduce the crash rate. 

https://codereview.chromium.org/371073003 will generate the crash dumps..