Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: Source/core/rendering/RenderGridTest.cpp

Issue 363133003: [CSS Grid Layout] Adapting align-self, align-items and justify-self to the last CSS 3 spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderGridTest.cpp
diff --git a/Source/core/rendering/RenderGridTest.cpp b/Source/core/rendering/RenderGridTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..5573a24c9f2ed16c3c0df9c0ae56dc86faff3bc2
--- /dev/null
+++ b/Source/core/rendering/RenderGridTest.cpp
@@ -0,0 +1,88 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/rendering/RenderGrid.h"
+
+#include "core/html/HTMLElement.h"
+
+#include "core/rendering/RenderObject.h"
+#include "core/rendering/RenderView.h"
+
+#include "core/testing/DummyPageHolder.h"
+#include <gtest/gtest.h>
+
+using namespace WebCore;
+
+namespace {
+
+// Base class for RenderGrid testing, it exposes some useful getter.
Julien - ping for review 2014/07/08 16:05:39 I don't think this is a RenderGrid testing, we onl
+class RenderGridTest : public testing::Test {
+protected:
+ virtual void SetUp() OVERRIDE
+ {
+ m_pageHolder = DummyPageHolder::create(IntSize(800, 600));
+
+ // This ensures that the minimal DOM tree gets attached
+ // correctly for tests that don't call setBodyInnerHTML.
+ document().view()->updateLayoutAndStyleIfNeededRecursive();
+ }
+
+ Document& document() const { return m_pageHolder->document(); }
+ RenderView& renderView() const { return *document().renderView(); }
+
+ void setBodyInnerHTML(const char*);
+
+private:
+ OwnPtr<DummyPageHolder> m_pageHolder;
+};
+
+void RenderGridTest::setBodyInnerHTML(const char* htmlContent)
+{
+ document().body()->setInnerHTML(String::fromUTF8(htmlContent), ASSERT_NO_EXCEPTION);
+ document().view()->updateLayoutAndStyleIfNeededRecursive();
+}
+
+TEST_F(RenderGridTest, JustifyItemsResolvedAutoValue)
+{
+ setBodyInnerHTML("<div style='display: grid; justify-items: auto'></div>");
+ RenderObject* renderer = document().body()->firstChild()->renderer();
+ EXPECT_EQ(renderer->isRenderGrid(), true);
+ EXPECT_EQ(ItemPositionStretch, renderer->style()->justifyItems());
+ EXPECT_EQ(OverflowAlignmentDefault, renderer->style()->justifyItemsOverflowAlignment());
+ EXPECT_EQ(NonLegacyPosition, renderer->style()->justifyItemsPositionType());
+}
+
+TEST_F(RenderGridTest, JustifySelfResolvedAutoValue)
+{
+ setBodyInnerHTML("<div style='display: grid; justify-items: right safe'><div style='display: grid; justify-self: auto'></div></div>");
+ RenderObject* container = document().body()->firstChild()->renderer();
+ RenderObject* renderer = toRenderBlock(container)->firstChild();
+ EXPECT_EQ(container->isRenderGrid(), true);
+ EXPECT_EQ(renderer->isRenderGrid(), true);
+ EXPECT_EQ(ItemPositionRight, renderer->style()->justifySelf());
+ EXPECT_EQ(OverflowAlignmentSafe, renderer->style()->justifySelfOverflowAlignment());
+}
+
+TEST_F(RenderGridTest, AlignItemsResolvedAutoValue)
+{
+ setBodyInnerHTML("<div style='display: grid; align-items: auto'></div>");
+ RenderObject* renderer = document().body()->firstChild()->renderer();
+ EXPECT_EQ(renderer->isRenderGrid(), true);
+ EXPECT_EQ(ItemPositionStretch, renderer->style()->alignItems());
+ EXPECT_EQ(OverflowAlignmentDefault, renderer->style()->alignItemsOverflowAlignment());
+}
+
+TEST_F(RenderGridTest, AlignSelfResolvedAutoValue)
+{
+ setBodyInnerHTML("<div style='display: grid; align-items: right safe'><div style='display: grid; align-self: auto'></div></div>");
+ RenderObject* container = document().body()->firstChild()->renderer();
+ RenderObject* renderer = toRenderBlock(container)->firstChild();
+ EXPECT_EQ(container->isRenderGrid(), true);
+ EXPECT_EQ(renderer->isRenderGrid(), true);
+ EXPECT_EQ(ItemPositionRight, renderer->style()->alignSelf());
+ EXPECT_EQ(OverflowAlignmentSafe, renderer->style()->alignSelfOverflowAlignment());
+}
+
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698