Source/core/rendering/style/RenderStyle.cpp - Issue 363133003: [CSS Grid Layout] Adapting align-self, align-items and justify-self to the last CSS 3 spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyle.cpp

Issue 363133003: [CSS Grid Layout] Adapting align-self, align-items and justify-self to the last CSS 3 spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Resolve grid and flex cases during cascade, the rest will wait for layout. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/style/RenderStyle.cpp

diff --git a/Source/core/rendering/style/RenderStyle.cpp b/Source/core/rendering/style/RenderStyle.cpp

index d89e8f6753fdc0e58afeeaa2c7cc5dd4aad2201b..ffab4cb95c459c751352745685fef42a434bbad5 100644

--- a/Source/core/rendering/style/RenderStyle.cpp

+++ b/Source/core/rendering/style/RenderStyle.cpp

@@ -179,7 +179,9 @@ StyleRecalcChange RenderStyle::stylePropagationDiff(const RenderStyle* oldStyle,

|| oldStyle->hasPseudoStyle(FIRST_LETTER) != newStyle->hasPseudoStyle(FIRST_LETTER)

|| oldStyle->columnSpan() != newStyle->columnSpan()

|| !oldStyle->contentDataEquivalent(newStyle)

- || oldStyle->hasTextCombine() != newStyle->hasTextCombine())

+ || oldStyle->hasTextCombine() != newStyle->hasTextCombine()

+ || oldStyle->justifyItems() != newStyle->justifyItems()

+ || oldStyle->alignItems() != newStyle->alignItems())

return Reattach;

if (*oldStyle == *newStyle)

« LayoutTests/fast/alignment/parse-align-items.html ('K') | « Source/core/rendering/style/RenderStyle.h ('k') | no next file » | no next file with comments »