Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: LayoutTests/fast/alignment/parse-justify-items.html

Issue 363133003: [CSS Grid Layout] Adapting align-self, align-items and justify-self to the last CSS 3 spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Resolve grid and flex cases during cascade, the rest will wait for layout. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/alignment/parse-justify-items.html
diff --git a/LayoutTests/fast/alignment/parse-justify-items.html b/LayoutTests/fast/alignment/parse-justify-items.html
index 0a8c7b27a94ecb9d05871f265432b80ee7749a57..f67e4f968eb85d1a05b5469e47254a7407c72dd7 100644
--- a/LayoutTests/fast/alignment/parse-justify-items.html
+++ b/LayoutTests/fast/alignment/parse-justify-items.html
@@ -257,8 +257,6 @@ checkValues(element, "justifyItems", "justify-items", "auto", "stretch");
element.style.display = "grid";
element.style.justifyItems = "auto";
checkValues(element, "justifyItems", "justify-items", "auto", "stretch");
-shouldBe("getComputedStyle(element, '').getPropertyValue('justify-items')", "'stretch'");
-shouldBe("element.style.justifyItems", "'auto'");
element.style.justifyItems = "self-end";
checkValues(element, "justifyItems", "justify-items", "self-end", "self-end");
@@ -295,27 +293,30 @@ checkBadValues(element, "justifyItems", "justify-items", "legacy left right");
debug("");
debug("Test the value 'initial'");
-checkInitialValues(element, "justifyItems", "justify-items", "", "legacy center");
+element.style.display = "";
+checkInitialValues(element, "justifyItems", "justify-items", "legacy center", "start");
debug("");
debug("Test the value 'initial' for grid containers");
-checkInitialValues(element, "justifyItems", "justify-items", "grid", "left safe");
+element.style.display = "grid";
+checkInitialValues(element, "justifyItems", "justify-items", "left safe", "stretch");
debug("");
debug("Test the value 'initial' for flex containers");
-checkInitialValues(element, "justifyItems", "justify-items", "flex", "right true");
+element.style.display = "flex";
+checkInitialValues(element, "justifyItems", "justify-items", "right true", "stretch");
debug("");
debug("Test the value 'inherit'");
-checkInheritValues(element, "justifyItems", "justify-items", "end");
-checkInheritValues(element, "justifyItems", "justify-items", "left safe");
-checkInheritValues(element, "justifyItems", "justify-items", "legacy center");
+checkInheritValues("justifyItems", "justify-items", "end");
+checkInheritValues("justifyItems", "justify-items", "left safe");
+checkInheritValues("justifyItems", "justify-items", "legacy center");
debug("");
debug("Test the value 'legacy'");
-checkLegacyValues(element, "justifyItems", "justify-items", "legacy left");
-checkLegacyValues(element, "justifyItems", "justify-items", "legacy center");
-checkLegacyValues(element, "justifyItems", "justify-items", "legacy right");
+checkLegacyValues("justifyItems", "justify-items", "legacy left");
+checkLegacyValues("justifyItems", "justify-items", "legacy center");
+checkLegacyValues("justifyItems", "justify-items", "legacy right");
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698