[CSS Grid Layout] Adapting align-self, align-items and justify-self to the last CSS 3 spec.

Source/core/rendering/style/RenderStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 161 matching lines @@
     if ((!oldStyle && newStyle) || (oldStyle && !newStyle))
         return Reattach;
 
     if (!oldStyle && !newStyle)
         return NoChange;
 
     if (oldStyle->display() != newStyle->display()
         || oldStyle->hasPseudoStyle(FIRST_LETTER) != newStyle->hasPseudoStyle(FIRST_LETTER)
         || oldStyle->columnSpan() != newStyle->columnSpan()
         || !oldStyle->contentDataEquivalent(newStyle)
-        || oldStyle->hasTextCombine() != newStyle->hasTextCombine())
+        || oldStyle->hasTextCombine() != newStyle->hasTextCombine()
+        || oldStyle->justifyItems() != newStyle->justifyItems()
+        || oldStyle->alignItems() != newStyle->alignItems())
         return Reattach;
 
     if (*oldStyle == *newStyle)
         return diffPseudoStyles(oldStyle, newStyle);
 
     if (oldStyle->inheritedNotEqual(newStyle)
         || oldStyle->hasExplicitlyInheritedProperties()
         || newStyle->hasExplicitlyInheritedProperties())
         return Inherit;
 
@@ skipping 1493 matching lines @@
 
     // right
     radiiSum = radii.topRight().height() + radii.bottomRight().height();
     if (radiiSum > rect.height())
         factor = std::min(rect.height() / radiiSum, factor);
 
     ASSERT(factor <= 1);
     return factor;
 }
 
+
+void RenderStyle::resolveJustifyItemsAuto(const RenderStyle& parentStyle)
+{
+    if (justifyItems() != ItemPositionAuto)
+        return;
+
+    // If the inherited value of justify-items includes the legacy keyword, 'auto'
+    // computes to the the inherited value.
+    // Otherwise, auto computes to:
+    //  - 'stretch' for flex containers and grid containers.
+    //  - 'start' for everything else.

[svillar, 2014/07/29 10:40:05]

I don't think you need these comments. Code is self-explanatory

+    if (parentStyle.justifyItemsPositionType() == LegacyPosition) {
+        setJustifyItems(parentStyle.justifyItems());
+        setJustifyItemsPositionType(parentStyle.justifyItemsPositionType());
+    } else if (isDisplayFlexibleOrGridBox()) {
+        setJustifyItems(ItemPositionStretch);
+    }
+}
+
+void RenderStyle::resolveJustifySelfAuto(const RenderStyle& parentStyle)
+{
+    if (justifySelf() != ItemPositionAuto)
+        return;
+
+    // The 'auto' keyword computes to 'stretch' on absolutely-positioned elements,
+    // and to the computed value of justify-items on the parent (minus
+    // any legacy keywords) on all other boxes.

[svillar, 2014/07/29 10:40:05]

Ditto.

+    if (position() == AbsolutePosition) {
+        setJustifySelf(ItemPositionStretch);
+    } else {
+        setJustifySelf(parentStyle.justifyItems());
+        setJustifySelfOverflowAlignment(parentStyle.justifyItemsOverflowAlignment());
+    }
+}
+
+void RenderStyle::resolveAlignItemsAuto(const RenderStyle& parentStyle)
+{
+    if (alignItems() != ItemPositionAuto)
+        return;
+
+    // The 'auto' keyword computes to:
+    // 'stretch' for flex containers and grid containers,
+    // 'start' for everything else.

[svillar, 2014/07/29 10:40:05]

Ditto.

+    if (isDisplayFlexibleOrGridBox())
+        setAlignItems(ItemPositionStretch);
+}
+
+void RenderStyle::resolveAlignSelfAuto(const RenderStyle& parentStyle)
+{
+    if (alignSelf() != ItemPositionAuto)
+        return;
+
+    // The 'auto' keyword computes to 'stretch' on absolutely-positioned elements,
+    // and to the computed value of align-items on the parent (minus
+    // any 'legacy' keywords) on all other boxes.

[svillar, 2014/07/29 10:40:05]

Ditto.

+    if ((position() == AbsolutePosition)) {
+        setAlignSelf(ItemPositionStretch);
+    } else {
+        setAlignSelf(parentStyle.alignItems());
+        setAlignSelfOverflowAlignment(parentStyle.alignItemsOverflowAlignment());
+    }
+}
+
 } // namespace blink