Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 363133002: Defer preparing for overview until all overview items are initialized. (Closed)

Created:
6 years, 5 months ago by flackr
Modified:
6 years, 5 months ago
Reviewers:
oshima, Nina
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Defer preparing for overview until all overview items are initialized. BUG=384495 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M ash/wm/overview/window_grid.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
flackr
I'm not sure why I haven't been able to reproduce this (manually or in a ...
6 years, 5 months ago (2014-07-02 22:35:20 UTC) #1
Nina
LGTM, a pity we can't reproduce it.
6 years, 5 months ago (2014-07-03 14:56:06 UTC) #2
oshima
lgtm This seems to happen when 1) there is a minimized window that a) is ...
6 years, 5 months ago (2014-07-08 20:39:07 UTC) #3
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 5 months ago (2014-07-08 20:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/363133002/1
6 years, 5 months ago (2014-07-08 20:43:54 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 04:06:45 UTC) #6
Message was sent while issue was closed.
Change committed as 281918

Powered by Google App Engine
This is Rietveld 408576698