Issue 36313002: [Object.observe] Implement implicit notification from performChange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36313002: [Object.observe] Implement implicit notification from performChange (Closed)

Created:
7 years, 2 months ago by rafaelw

Modified:
7 years, 1 month ago

Reviewers:
arv (Not doing code reviews), rossberg

CC:
v8-dev, adamk, arv (Not doing code reviews)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

[Object.observe] Implement implicit notification from performChange R=arv@chromium.org, rossberg@chromium.org, rossberg BUG=v8:2942 Committed: https://code.google.com/p/v8/source/detail?r=17476

Patch Set 3 : moar #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -36 lines)			Patch
	M	src/object-observe.js	View	1 2	5 chunks	+31 lines, -18 lines	1 comment	Download
	M	test/mjsunit/harmony/object-observe.js	View		5 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM https://codereview.chromium.org/36313002/diff/50001/src/object-observe.js File src/object-observe.js (right): https://codereview.chromium.org/36313002/diff/50001/src/object-observe.js#newcode398 src/object-observe.js:398: for (var prop in changeRecord) { Do we ...

7 years, 2 months ago (2013-10-23 14:48:34 UTC) #2

rafaelw

7 years, 1 month ago (2013-11-05 11:23:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r17476 (presubmit successful).

Expand Messages | Collapse Messages

Issue 36313002: [Object.observe] Implement implicit notification from performChange (Closed)

Description

Patch Set 1 #

Patch Set 2 : re-org #

Patch Set 3 : moar #

Messages