Update recurselist to be a set, call it recursedeps now.

gclient.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Meta checkout manager supporting both Subversion and GIT."""
 # Files
 #   .gclient      : Current client configuration, written by 'config' command.
 #                   Format is a Python script defining 'solutions', a list whose
 #                   entries each are maps binding the strings "name" and "url"
@@ skipping 293 matching lines @@
     self._used_scm = None
     self._used_revision = None
     # The actual revision we ended up getting, or None if that information is
     # unavailable
     self._got_revision = None
 
     # This is a mutable value that overrides the normal recursion limit for this
     # dependency.  It is read from the actual DEPS file so cannot be set on
     # class instantiation.
     self.recursion_override = None
-    # recurselist is a mutable value that selectively overrides the default
+    # recursedeps is a mutable value that selectively overrides the default
     # 'no recursion' setting on a dep-by-dep basis.  It will replace
     # recursion_override.
-    self.recurselist = None
+    self.recursedeps = None
 
     if not self.name and self.parent:
       raise gclient_utils.Error('Dependency without name')
 
   @property
   def requirements(self):
     """Calculate the list of requirements."""
     requirements = set()
     # self.parent is implicitly a requirement. This will be recursive by
     # definition.
@@ skipping 21 matching lines @@
       requirements |= set(
           obj.name for obj in self.root.subtree(False)
           if (obj is not self
               and obj.name and
               self.name.startswith(posixpath.join(obj.name, ''))))
     requirements = tuple(sorted(requirements))
     logging.info('Dependency(%s).requirements = %s' % (self.name, requirements))
     return requirements
 
   @property
-  def try_recurselist(self):
+  def try_recursedeps(self):
     """Returns False if recursion_override is ever specified."""
     if self.recursion_override is not None:
       return False
-    return self.parent.try_recurselist
+    return self.parent.try_recursedeps
 
   @property
   def recursion_limit(self):
     """Returns > 0 if this dependency is not too recursed to be processed."""
-    # We continue to support the absence of recurselist until tools and DEPS
+    # We continue to support the absence of recursedeps until tools and DEPS
     # using recursion_override are updated.
-    if self.try_recurselist and self.parent.recurselist != None:
-      if self.name in self.parent.recurselist:
+    if self.try_recursedeps and self.parent.recursedeps != None:
+      if self.name in self.parent.recursedeps:
         return 1
 
     if self.recursion_override is not None:
       return self.recursion_override
     return max(self.parent.recursion_limit - 1, 0)
 
   def verify_validity(self):
     """Verifies that this Dependency is fine to add as a child of another one.
 
     Returns True if this entry should be added, False if it is a duplicate of
@@ skipping 204 matching lines @@
           if not isinstance(val, (dict, list, tuple, str)):
             raise gclient_utils.Error(
               'ParseDepsFile(%s): Strict mode disallows %r -> %r' %
               (self.name, key, val))
 
     deps = local_scope.get('deps', {})
     if 'recursion' in local_scope:
       self.recursion_override = local_scope.get('recursion')
       logging.warning(
           'Setting %s recursion to %d.', self.name, self.recursion_limit)
-    self.recurselist = local_scope.get('recurselist', None)
-    if 'recurselist' in local_scope:
-      logging.warning('Found recurselist %r.', repr(self.recurselist))
+    self.recursedeps = local_scope.get('recursedeps', None)

[iannucci, 2014/07/03 18:55:59]

could also cast to a set here. If it's already a set then it shouldn't do
anything. If not, then everything else won't be assuming set and actually
dealing with e.g. list, tuple, dict, etc.

+    if 'recursedeps' in local_scope:
+      logging.warning('Found recursedeps %r.', repr(self.recursedeps))
     # If present, save 'target_os' in the local_target_os property.
     if 'target_os' in local_scope:
       self.local_target_os = local_scope['target_os']
     # load os specific dependencies if defined.  these dependencies may
     # override or extend the values defined by the 'deps' member.
     target_os_list = self.target_os
     if 'deps_os' in local_scope and target_os_list:
       deps = self.MergeWithOsDeps(deps, local_scope['deps_os'], target_os_list)
 
     # If a line is in custom_deps, but not in the solution, we want to append
@@ skipping 874 matching lines @@
   def enforced_os(self):
     """What deps_os entries that are to be parsed."""
     return self._enforced_os
 
   @property
   def recursion_limit(self):
     """How recursive can each dependencies in DEPS file can load DEPS file."""
     return self._recursion_limit
 
   @property
-  def try_recurselist(self):
-    """Whether to attempt using recurselist-style recursion processing."""
+  def try_recursedeps(self):
+    """Whether to attempt using recursedeps-style recursion processing."""
     return True
 
   @property
   def target_os(self):
     return self._enforced_os
 
 
 #### gclient commands.
 
 
@@ skipping 540 matching lines @@
     print >> sys.stderr, 'Error: %s' % str(e)
     return 1
   finally:
     gclient_utils.PrintWarnings()
 
 
 if '__main__' == __name__:
   sys.exit(Main(sys.argv[1:]))
 
 # vim: ts=2:sw=2:tw=80:et: