Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 363093003: Always run AudioRendererImpl's flush callback asynchronously. (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Always run AudioRendererImpl's flush callback asynchronously. It's possible to hit Pipeline's DCHECK that verifies renderers have reset their buffering state after flushing since AudioRendererImpl always runs buffering state changes asynchronously but ran the flush callback synchronously. BUG=389104 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M media/filters/audio_renderer_impl.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M tools/valgrind/gtest_exclude/media_unittests.gtest_mac.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
tricky :\
6 years, 5 months ago (2014-07-02 20:35:29 UTC) #1
xhwang
This CL lgtm. But in VRI, the buffering_state_cb_ isn't posted. We probably should make ARI ...
6 years, 5 months ago (2014-07-02 20:51:40 UTC) #2
scherkus (not reviewing)
On 2014/07/02 20:51:40, xhwang wrote: > This CL lgtm. But in VRI, the buffering_state_cb_ isn't ...
6 years, 5 months ago (2014-07-02 20:54:20 UTC) #3
xhwang
On 2014/07/02 20:54:20, scherkus wrote: > On 2014/07/02 20:51:40, xhwang wrote: > > This CL ...
6 years, 5 months ago (2014-07-02 20:58:12 UTC) #4
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-02 21:05:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/363093003/1
6 years, 5 months ago (2014-07-02 21:06:03 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 03:28:14 UTC) #7
Message was sent while issue was closed.
Change committed as 281156

Powered by Google App Engine
This is Rietveld 408576698