Issue 363083004: Adding a landmine to clobber due to NDEBUG nacl change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363083004: Adding a landmine to clobber due to NDEBUG nacl change. (Closed)

Created:
6 years, 5 months ago by bradn

Modified:
6 years, 5 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adding a landmine to clobber due to NDEBUG nacl change. BUG=391093 R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281106

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	build/get_landmines.py	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

lgtm https://codereview.chromium.org/363083004/diff/1/build/get_landmines.py File build/get_landmines.py (right): https://codereview.chromium.org/363083004/diff/1/build/get_landmines.py#newcode57 build/get_landmines.py:57: print 'Need to clobber everything due to build_nexe ...

6 years, 5 months ago (2014-07-02 23:04:48 UTC) #2

bradn

6 years, 5 months ago (2014-07-02 23:11:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r281106 (tree was closed).

Expand Messages | Collapse Messages