Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 363073002: One of the fast cases in JSObject::MigrateFastToFast() should not be taken... (Closed)

Created:
6 years, 5 months ago by Igor Sheludko
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

One of the fast cases in JSObject::MigrateFastToFast() should not be taken if the number of fields did not change. BUG=chromium:390918 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22174

Patch Set 1 #

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/objects.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects.cc View 1 3 chunks +11 lines, -9 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-390918.js View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 5 months ago (2014-07-02 17:53:32 UTC) #1
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-02 18:19:19 UTC) #2
Igor Sheludko
6 years, 5 months ago (2014-07-02 19:11:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698