Issue 363033004: Mojo: bindings generator: Add an AST type for parameter lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363033004: Mojo: bindings generator: Add an AST type for parameter lists. (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: bindings generator: Add an AST type for parameter lists. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281112

Patch Set 1 #

Patch Set 2 : rebased #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -20 lines)			Patch
M	mojo/public/tools/bindings/pylib/mojom/parse/ast.py	View		3 chunks	+55 lines, -5 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/parse/parser.py	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom/parse/translate.py	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py	View		3 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

(Dependent on https://codereview.chromium.org/364003002/.)

6 years, 5 months ago (2014-07-02 20:06:10 UTC) #1

jamesr

you know I don't understand this "lanaguage" you want me to "review" but lgtm

6 years, 5 months ago (2014-07-02 22:01:37 UTC) #2

viettrungluu

6 years, 5 months ago (2014-07-02 23:38:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r281112 (presubmit successful).

Expand Messages | Collapse Messages