pkg/custom_element/lib/custom-elements.debug.js - Issue 36303003: Closing register/upgrade timing hole primarily impacting IE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/custom_element/lib/custom-elements.debug.js

Issue 36303003: Closing register/upgrade timing hole primarily impacting IE (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/custom_element/lib/custom-elements.debug.js

diff --git a/pkg/custom_element/lib/custom-elements.debug.js b/pkg/custom_element/lib/custom-elements.debug.js

index 07e93804514da025fc5db252325e12e9436c61c0..510dc2cea79cb52e089d49cf6129125b59c2991c 100644

--- a/pkg/custom_element/lib/custom-elements.debug.js

+++ b/pkg/custom_element/lib/custom-elements.debug.js

@@ -1063,7 +1063,7 @@ if (useNative) {

// force our .constructor to be our actual constructor

definition.prototype.constructor = definition.ctor;

// if initial parsing is complete

- if (scope.ready) {

+ if (scope.ready || scope.performedInitialDocumentUpgrade) {

// upgrade any pre-existing nodes of this type

scope.upgradeAll(document);

}

@@ -1385,6 +1385,7 @@ function bootstrap() {

CustomElements.parser.parse(document);

// one more pass before register is 'live'

CustomElements.upgradeDocument(document);

+ CustomElements.performedInitialDocumentUpgrade = true;

// choose async

var async = window.Platform && Platform.endOfMicrotask ?

Platform.endOfMicrotask :

« no previous file with comments | « no previous file | pkg/custom_element/lib/custom-elements.min.js » ('j') | no next file with comments »