Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: chrome/browser/profiles/profile_manager.cc

Issue 363013003: Remove passwords from the keychain if the profile is destroyed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: The new comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_manager_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/profile_manager.h" 5 #include "chrome/browser/profiles/profile_manager.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/debug/trace_event.h" 11 #include "base/debug/trace_event.h"
12 #include "base/deferred_sequenced_task_runner.h" 12 #include "base/deferred_sequenced_task_runner.h"
13 #include "base/file_util.h" 13 #include "base/file_util.h"
14 #include "base/files/file_enumerator.h" 14 #include "base/files/file_enumerator.h"
15 #include "base/files/file_path.h" 15 #include "base/files/file_path.h"
16 #include "base/metrics/histogram.h" 16 #include "base/metrics/histogram.h"
17 #include "base/prefs/pref_service.h" 17 #include "base/prefs/pref_service.h"
18 #include "base/prefs/scoped_user_pref_update.h" 18 #include "base/prefs/scoped_user_pref_update.h"
19 #include "base/strings/string_number_conversions.h" 19 #include "base/strings/string_number_conversions.h"
20 #include "base/strings/string_util.h" 20 #include "base/strings/string_util.h"
21 #include "base/strings/utf_string_conversions.h" 21 #include "base/strings/utf_string_conversions.h"
22 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 22 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
23 #include "chrome/browser/browser_process.h" 23 #include "chrome/browser/browser_process.h"
24 #include "chrome/browser/chrome_notification_types.h" 24 #include "chrome/browser/chrome_notification_types.h"
25 #include "chrome/browser/content_settings/host_content_settings_map.h" 25 #include "chrome/browser/content_settings/host_content_settings_map.h"
26 #include "chrome/browser/download/download_service.h" 26 #include "chrome/browser/download/download_service.h"
27 #include "chrome/browser/download/download_service_factory.h" 27 #include "chrome/browser/download/download_service_factory.h"
28 #include "chrome/browser/password_manager/password_store_factory.h"
28 #include "chrome/browser/prefs/incognito_mode_prefs.h" 29 #include "chrome/browser/prefs/incognito_mode_prefs.h"
29 #include "chrome/browser/profiles/bookmark_model_loaded_observer.h" 30 #include "chrome/browser/profiles/bookmark_model_loaded_observer.h"
30 #include "chrome/browser/profiles/profile_avatar_icon_util.h" 31 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
31 #include "chrome/browser/profiles/profile_destroyer.h" 32 #include "chrome/browser/profiles/profile_destroyer.h"
32 #include "chrome/browser/profiles/profile_info_cache.h" 33 #include "chrome/browser/profiles/profile_info_cache.h"
33 #include "chrome/browser/profiles/profile_metrics.h" 34 #include "chrome/browser/profiles/profile_metrics.h"
34 #include "chrome/browser/profiles/profiles_state.h" 35 #include "chrome/browser/profiles/profiles_state.h"
35 #include "chrome/browser/profiles/startup_task_runner_service.h" 36 #include "chrome/browser/profiles/startup_task_runner_service.h"
36 #include "chrome/browser/profiles/startup_task_runner_service_factory.h" 37 #include "chrome/browser/profiles/startup_task_runner_service_factory.h"
37 #include "chrome/browser/signin/account_reconcilor_factory.h" 38 #include "chrome/browser/signin/account_reconcilor_factory.h"
38 #include "chrome/browser/sync/profile_sync_service.h" 39 #include "chrome/browser/sync/profile_sync_service.h"
39 #include "chrome/browser/sync/profile_sync_service_factory.h" 40 #include "chrome/browser/sync/profile_sync_service_factory.h"
40 #include "chrome/browser/ui/browser.h" 41 #include "chrome/browser/ui/browser.h"
41 #include "chrome/browser/ui/browser_iterator.h" 42 #include "chrome/browser/ui/browser_iterator.h"
42 #include "chrome/browser/ui/sync/sync_promo_ui.h" 43 #include "chrome/browser/ui/sync/sync_promo_ui.h"
43 #include "chrome/common/chrome_constants.h" 44 #include "chrome/common/chrome_constants.h"
44 #include "chrome/common/chrome_paths_internal.h" 45 #include "chrome/common/chrome_paths_internal.h"
45 #include "chrome/common/chrome_switches.h" 46 #include "chrome/common/chrome_switches.h"
46 #include "chrome/common/logging_chrome.h" 47 #include "chrome/common/logging_chrome.h"
47 #include "chrome/common/pref_names.h" 48 #include "chrome/common/pref_names.h"
48 #include "chrome/common/url_constants.h" 49 #include "chrome/common/url_constants.h"
49 #include "components/bookmarks/browser/bookmark_model.h" 50 #include "components/bookmarks/browser/bookmark_model.h"
51 #include "components/password_manager/core/browser/password_store.h"
50 #include "components/signin/core/common/profile_management_switches.h" 52 #include "components/signin/core/common/profile_management_switches.h"
51 #include "content/public/browser/browser_thread.h" 53 #include "content/public/browser/browser_thread.h"
52 #include "content/public/browser/notification_service.h" 54 #include "content/public/browser/notification_service.h"
53 #include "content/public/browser/user_metrics.h" 55 #include "content/public/browser/user_metrics.h"
54 #include "extensions/browser/extension_registry.h" 56 #include "extensions/browser/extension_registry.h"
55 #include "extensions/common/extension_set.h" 57 #include "extensions/common/extension_set.h"
56 #include "extensions/common/manifest.h" 58 #include "extensions/common/manifest.h"
57 #include "grit/generated_resources.h" 59 #include "grit/generated_resources.h"
58 #include "net/http/http_transaction_factory.h" 60 #include "net/http/http_transaction_factory.h"
59 #include "net/url_request/url_request_context.h" 61 #include "net/url_request/url_request_context.h"
(...skipping 1041 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 // Disable sync for doomed profile. 1103 // Disable sync for doomed profile.
1102 if (ProfileSyncServiceFactory::GetInstance()->HasProfileSyncService( 1104 if (ProfileSyncServiceFactory::GetInstance()->HasProfileSyncService(
1103 profile)) { 1105 profile)) {
1104 ProfileSyncServiceFactory::GetInstance()->GetForProfile( 1106 ProfileSyncServiceFactory::GetInstance()->GetForProfile(
1105 profile)->DisableForUser(); 1107 profile)->DisableForUser();
1106 } 1108 }
1107 1109
1108 bool profile_is_signed_in = !cache.GetUserNameOfProfileAtIndex( 1110 bool profile_is_signed_in = !cache.GetUserNameOfProfileAtIndex(
1109 cache.GetIndexOfProfileWithPath(profile_dir)).empty(); 1111 cache.GetIndexOfProfileWithPath(profile_dir)).empty();
1110 ProfileMetrics::LogProfileDelete(profile_is_signed_in); 1112 ProfileMetrics::LogProfileDelete(profile_is_signed_in);
1113 // Some platforms store passwords in keychains. They should be removed.
1114 scoped_refptr<password_manager::PasswordStore> password_store =
1115 PasswordStoreFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS)
1116 .get();
1117 if (password_store) {
1118 password_store->RemoveLoginsCreatedBetween(base::Time(),
1119 base::Time::Max());
1120 }
1111 } 1121 }
1112 1122
1113 QueueProfileDirectoryForDeletion(profile_dir); 1123 QueueProfileDirectoryForDeletion(profile_dir);
1114 cache.DeleteProfileFromCache(profile_dir); 1124 cache.DeleteProfileFromCache(profile_dir);
1115 ProfileMetrics::UpdateReportedProfilesStatistics(this); 1125 ProfileMetrics::UpdateReportedProfilesStatistics(this);
1116 } 1126 }
1117 1127
1118 ProfileManager::ProfileInfo* ProfileManager::RegisterProfile( 1128 ProfileManager::ProfileInfo* ProfileManager::RegisterProfile(
1119 Profile* profile, 1129 Profile* profile,
1120 bool created) { 1130 bool created) {
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 last_non_supervised_profile_path.BaseName().MaybeAsASCII()); 1307 last_non_supervised_profile_path.BaseName().MaybeAsASCII());
1298 FinishDeletingProfile(profile_to_delete_path); 1308 FinishDeletingProfile(profile_to_delete_path);
1299 } 1309 }
1300 } 1310 }
1301 } 1311 }
1302 #endif 1312 #endif
1303 1313
1304 ProfileManagerWithoutInit::ProfileManagerWithoutInit( 1314 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
1305 const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) { 1315 const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
1306 } 1316 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_manager_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698