Add duration estimation data to RenderingStats.

cc/trees/thread_proxy.cc

Index: cc/trees/thread_proxy.cc
diff --git a/cc/trees/thread_proxy.cc b/cc/trees/thread_proxy.cc
index d62b96ef1c02e9377484b1a7fba03c6e3004a692..d1e46b9acf70aa29cb045518780eb00dc59dd6c5 100644
--- a/cc/trees/thread_proxy.cc
+++ b/cc/trees/thread_proxy.cc
@@ -1005,7 +1005,17 @@ void ThreadProxy::ScheduledActionCommit() {
 
   impl().next_frame_is_newly_committed_frame = true;
 
-  impl().timing_history.DidCommit();
+  // Compute the estimate before we add the new duration so we can compare the
+  // estimated duration for this frame to the actual value.
+  base::TimeDelta begin_main_frame_to_commit_duration_estimate =
+      BeginMainFrameToCommitDurationEstimate();
+  base::TimeDelta begin_main_frame_to_commit_duration =
+      impl().timing_history.DidCommit();
+  impl()
+      .layer_tree_host_impl->rendering_stats_instrumentation()

[danakj, 2014/07/11 18:16:18]

I don't think ThreadProxy should be reaching through LTHI to the renderering
stats instrumentation. Can we make these calls from LTHI methods?

[ernstm, 2014/07/14 13:12:38]

ThreadProxy could access RenderingStatsInstrumentation through LayerTreeHost.

[Dominik Grewe, 2014/07/14 13:37:52]

As far as I understand, this method is always running on the compositor thread
(see DCHECK above), so we can't access LayerTreeHost.

I've added AddDrawDurationEstimate etc methods to LTHI so we can call into those
methods from ThreadProxy without exposing rendering_stats_instrumentation. Dana,
is this what you had in mind?

[ernstm, 2014/07/14 14:05:26]

I liked the version that exposes rendering_stats_instrumentation on LTHI a bit
better. rendering_stats_instrumentation is kind of global in cc already, because
it needs to accumulate stats from many places (similar to tracing for all of
Chrome). Dana, why would you prefer to not expose it on LTHI?

+      ->AddBeginMainFrameToCommitDuration(
+          begin_main_frame_to_commit_duration,
+          begin_main_frame_to_commit_duration_estimate);
 }
 
 void ThreadProxy::ScheduledActionUpdateVisibleTiles() {
@@ -1137,6 +1147,10 @@ DrawResult ThreadProxy::DrawSwapInternal(bool forced_draw) {
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMilliseconds(100),
                                50);
+
+    impl()
+        .layer_tree_host_impl->rendering_stats_instrumentation()
+        ->AddDrawDuration(draw_duration, draw_duration_estimate);
   }
 
   DCHECK_NE(INVALID_RESULT, result);
@@ -1433,7 +1447,16 @@ void ThreadProxy::DidActivateSyncTree() {
 
   UpdateBackgroundAnimateTicking();
 
-  impl().timing_history.DidActivatePendingTree();
+  // Compute the estimate before we add the new duration so we can compare the
+  // estimated duration for this frame to the actual value.
+  base::TimeDelta commit_to_activate_duration_estimate =
+      CommitToActivateDurationEstimate();
+  base::TimeDelta commit_to_activate_duration =
+      impl().timing_history.DidActivatePendingTree();
+  impl()
+      .layer_tree_host_impl->rendering_stats_instrumentation()
+      ->AddCommitToActivateDuration(commit_to_activate_duration,
+                                    commit_to_activate_duration_estimate);
 }
 
 void ThreadProxy::DidManageTiles() {