Add duration estimation data to RenderingStats.

cc/trees/thread_proxy.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/thread_proxy.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 987 matching lines @@
   // Delay this step until afer the main thread has been released as it's
   // often a good bit of work to update the tree and prepare the new frame.
   impl().layer_tree_host_impl->CommitComplete();
 
   SetInputThrottledUntilCommitOnImplThread(false);
 
   UpdateBackgroundAnimateTicking();
 
   impl().next_frame_is_newly_committed_frame = true;
 
-  impl().timing_history.DidCommit();
+  base::TimeDelta begin_main_frame_to_commit_duration_estimate =
+      BeginMainFrameToCommitDurationEstimate();

[brianderson, 2014/07/02 22:39:29]

Can you add a comment indicating why you are taking the estimate before adding
the next sample to the timing history? I agree that this should be the approach,
but it's not immediately obvious.

[Dominik Grewe, 2014/07/03 13:16:38]

Done here and below.

+  base::TimeDelta begin_main_frame_to_commit_duration =
+      impl().timing_history.DidCommit();
+  impl()
+      .layer_tree_host_impl->rendering_stats_instrumentation()
+      ->AddBeginMainFrameToCommitDuration(
+          begin_main_frame_to_commit_duration,
+          begin_main_frame_to_commit_duration_estimate);
 }
 
 void ThreadProxy::ScheduledActionUpdateVisibleTiles() {
   TRACE_EVENT0("cc", "ThreadProxy::ScheduledActionUpdateVisibleTiles");
   DCHECK(IsImplThread());
   impl().layer_tree_host_impl->UpdateVisibleTiles();
 }
 
 void ThreadProxy::ScheduledActionActivatePendingTree() {
   TRACE_EVENT0("cc", "ThreadProxy::ScheduledActionActivatePendingTree");
@@ skipping 111 matching lines @@
     UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDurationUnderestimate",
                                draw_duration_underestimate,
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMilliseconds(100),
                                50);
     UMA_HISTOGRAM_CUSTOM_TIMES("Renderer.DrawDurationOverestimate",
                                draw_duration_overestimate,
                                base::TimeDelta::FromMilliseconds(1),
                                base::TimeDelta::FromMilliseconds(100),
                                50);
+
+    impl()
+        .layer_tree_host_impl->rendering_stats_instrumentation()
+        ->AddDrawDuration(draw_duration, draw_duration_estimate);
   }
 
   DCHECK_NE(INVALID_RESULT, result);
   return result;
 }
 
 void ThreadProxy::ScheduledActionManageTiles() {
   TRACE_EVENT0("cc", "ThreadProxy::ScheduledActionManageTiles");
   DCHECK(impl().layer_tree_host_impl->settings().impl_side_painting);
   impl().layer_tree_host_impl->ManageTiles();
@@ skipping 276 matching lines @@
   if (impl().completion_event_for_commit_held_on_tree_activation) {
     TRACE_EVENT_INSTANT0(
         "cc", "ReleaseCommitbyActivation", TRACE_EVENT_SCOPE_THREAD);
     DCHECK(impl().layer_tree_host_impl->settings().impl_side_painting);
     impl().completion_event_for_commit_held_on_tree_activation->Signal();
     impl().completion_event_for_commit_held_on_tree_activation = NULL;
   }
 
   UpdateBackgroundAnimateTicking();
 
-  impl().timing_history.DidActivatePendingTree();
+  base::TimeDelta commit_to_activate_duration_estimate =
+      CommitToActivateDurationEstimate();
+  base::TimeDelta commit_to_activate_duration =
+      impl().timing_history.DidActivatePendingTree();
+  impl()
+      .layer_tree_host_impl->rendering_stats_instrumentation()
+      ->AddCommitToActivateDuration(commit_to_activate_duration,
+                                    commit_to_activate_duration_estimate);
 }
 
 void ThreadProxy::DidManageTiles() {
   DCHECK(IsImplThread());
   impl().scheduler->DidManageTiles();
 }
 
 }  // namespace cc