Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: cc/debug/rendering_stats_unittest.cc

Issue 363003002: Add duration estimation data to RenderingStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nest classes inside RenderingStats; add tests for TimeDeltaList Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/debug/rendering_stats_instrumentation.cc ('k') | cc/trees/proxy_timing_history.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "base/time/time.h"
6 #include "base/values.h"
7 #include "cc/debug/rendering_stats.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 namespace cc {
11 namespace {
12
13 void CompareDoubleValue(const base::ListValue& list_value,
14 int index,
15 double expected_value) {
16 double value;
17 EXPECT_TRUE(list_value.GetDouble(index, &value));
18 EXPECT_EQ(expected_value, value);
19 }
20
21 TEST(RenderingStatsTest, TimeDeltaListEmpty) {
22 RenderingStats::TimeDeltaList time_delta_list;
23 scoped_ptr<base::ListValue> list_value =
24 time_delta_list.AsListValueInMilliseconds();
25 EXPECT_TRUE(list_value->empty());
26 }
danakj 2014/07/18 15:34:46 Expect_eq(0, getsize) too?
Dominik Grewe 2014/07/18 17:16:40 Done.
27
28 TEST(RenderingStatsTest, TimeDeltaListNonEmpty) {
29 RenderingStats::TimeDeltaList time_delta_list;
30 time_delta_list.Append(base::TimeDelta::FromMilliseconds(234));
31 time_delta_list.Append(base::TimeDelta::FromMilliseconds(827));
32
33 scoped_ptr<base::ListValue> list_value =
34 time_delta_list.AsListValueInMilliseconds();
35 EXPECT_EQ(2ul, list_value->GetSize());
36
danakj 2014/07/18 15:34:46 Expect_false(empty) too?
Dominik Grewe 2014/07/18 17:16:40 Done.
37 CompareDoubleValue(*list_value.get(), 0, 234);
38 CompareDoubleValue(*list_value.get(), 1, 827);
39 }
40
41 TEST(RenderingStatsTest, TimeDeltaListAdd) {
42 RenderingStats::TimeDeltaList time_delta_list_a;
43 time_delta_list_a.Append(base::TimeDelta::FromMilliseconds(810));
44 time_delta_list_a.Append(base::TimeDelta::FromMilliseconds(32));
45
46 RenderingStats::TimeDeltaList time_delta_list_b;
47 time_delta_list_b.Append(base::TimeDelta::FromMilliseconds(43));
48 time_delta_list_b.Append(base::TimeDelta::FromMilliseconds(938));
49 time_delta_list_b.Append(base::TimeDelta::FromMilliseconds(2));
50
51 time_delta_list_a.Add(time_delta_list_b);
52 scoped_ptr<base::ListValue> list_value =
53 time_delta_list_a.AsListValueInMilliseconds();
54 EXPECT_EQ(5ul, list_value->GetSize());
55
56 CompareDoubleValue(*list_value.get(), 0, 810);
57 CompareDoubleValue(*list_value.get(), 1, 32);
58 CompareDoubleValue(*list_value.get(), 2, 43);
59 CompareDoubleValue(*list_value.get(), 3, 938);
60 CompareDoubleValue(*list_value.get(), 4, 2);
61 }
62
63 } // namespace
64 } // namespace cc
OLDNEW
« no previous file with comments | « cc/debug/rendering_stats_instrumentation.cc ('k') | cc/trees/proxy_timing_history.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698