Add duration estimation data to RenderingStats.

cc/debug/rendering_stats.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_DEBUG_RENDERING_STATS_H_
 #define CC_DEBUG_RENDERING_STATS_H_
 
+#include <list>
+
 #include "base/basictypes.h"
 #include "base/time/time.h"
 #include "cc/base/cc_export.h"
 #include "cc/debug/traced_value.h"
 
 namespace cc {
 
 struct CC_EXPORT MainThreadRenderingStats {
-  // Note: when adding new members, please remember to update EnumerateFields
-  // and Add in rendering_stats.cc.
+  // Note: when adding new members, please remember to update Add in
+  // rendering_stats.cc.
 
   int64 frame_count;
   base::TimeDelta paint_time;
   int64 painted_pixel_count;
   base::TimeDelta record_time;
   int64 recorded_pixel_count;
 
   MainThreadRenderingStats();
+  ~MainThreadRenderingStats();
   scoped_refptr<base::debug::ConvertableToTraceFormat> AsTraceableData() const;
   void Add(const MainThreadRenderingStats& other);
 };
 
+// Stores a sequence of TimeDelta objects.
+class CC_EXPORT TimeDeltaList {

[danakj, 2014/07/17 14:49:35]

can this be a tested class inside ImplThreadRenderingStats? Otherwise it should
be in its own file as per style guide.

[ernstm, 2014/07/17 15:27:54]

This should not be inside ImplThreadRenderingStats, as it could potentially be
used in MainThreadRenderingStats as well.

[danakj, 2014/07/17 15:42:59]

Oh, though it's not currently.

Technically this file already has 3 classes in it which is wrong. Maybe
Main/Impl stats should be nested in RenderingStats. Then this could be nested
there too at the same level and used by both.

This is just style nits, so idk, but we should have 1 class per file.

[Dominik Grewe, 2014/07/18 14:27:20]

I've nested the classes inside RenderingStats and added some simple unit tests
for TimeDeltaList. Ptal.

+ public:
+  TimeDeltaList();
+  ~TimeDeltaList();
+
+  void Append(base::TimeDelta value);
+  scoped_ptr<base::ListValue> AsListValueInMilliseconds() const;
+  void Add(const TimeDeltaList& other);
+
+ private:
+  std::list<base::TimeDelta> values;
+};
+
 struct CC_EXPORT ImplThreadRenderingStats {
-  // Note: when adding new members, please remember to update EnumerateFields
-  // and Add in rendering_stats.cc.
+  // Note: when adding new members, please remember to update Add in
+  // rendering_stats.cc.
 
   int64 frame_count;
   base::TimeDelta rasterize_time;
   base::TimeDelta analysis_time;
   int64 rasterized_pixel_count;
   int64 visible_content_area;
   int64 approximated_visible_content_area;
 
+  TimeDeltaList draw_duration;
+  TimeDeltaList draw_duration_estimate;
+  TimeDeltaList begin_main_frame_to_commit_duration;
+  TimeDeltaList begin_main_frame_to_commit_duration_estimate;
+  TimeDeltaList commit_to_activate_duration;
+  TimeDeltaList commit_to_activate_duration_estimate;
+
   ImplThreadRenderingStats();
+  ~ImplThreadRenderingStats();
   scoped_refptr<base::debug::ConvertableToTraceFormat> AsTraceableData() const;
   void Add(const ImplThreadRenderingStats& other);
 };
 
 struct CC_EXPORT RenderingStats {
   MainThreadRenderingStats main_stats;
   ImplThreadRenderingStats impl_stats;
 
   // Add fields of |other| to the fields in this structure.
   void Add(const RenderingStats& other);
 };
 
 }  // namespace cc
 
 #endif  // CC_DEBUG_RENDERING_STATS_H_