Source/bindings/scripts/v8_private_script_interface.py - Issue 362993004: Implement Blink-in-JS for DOM attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_private_script_interface.py

Issue 362993004: Implement Blink-in-JS for DOM attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_private_script_interface.py

diff --git a/Source/bindings/scripts/v8_private_script_interface.py b/Source/bindings/scripts/v8_private_script_interface.py

index ab6f4de577905f0f0fb2d73076a6bdf2b0baa83b..c4d16c594a12827ffa6aae46d18f9dbdc3c91ad4 100644

--- a/Source/bindings/scripts/v8_private_script_interface.py

+++ b/Source/bindings/scripts/v8_private_script_interface.py

@@ -56,8 +56,7 @@ def method_context(operation):

'cpp_type': idl_type.cpp_type_args(raw_type=True),

'name': operation.name,

'v8_value_to_cpp_value': v8_types.v8_value_to_cpp_value(

- idl_type, extended_attributes, 'v8Value', 0,

- isolate='scriptState->isolate()'),

+ idl_type, extended_attributes, 'v8Value', 0, 'scriptState->isolate()'),

}

contents.update(arguments_context(operation.arguments, idl_type))

return contents