Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 362993004: Implement Blink-in-JS for DOM attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 83d83adae04732b2cc3a8c05860391a89c462b7f..d57ac5e9ecfd83b13d64d4f6bc4bc86b8f243310 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -514,7 +514,7 @@ static bool {{method.name}}MethodImplementedInPrivateScript({{method.argument_de
// FIXME: Support exceptions thrown from Blink-in-JS.
v8::TryCatch block;
{% if method.returned_v8_value_to_local_cpp_value %}
- v8::Handle<v8::Value> v8Value = PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
+ v8::Handle<v8::Value> v8Value = PrivateScriptRunner::run(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
if (block.HasCaught())
return false;
ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{cpp_class}}", scriptState->context()->Global(), scriptState->isolate());
@@ -523,7 +523,7 @@ static bool {{method.name}}MethodImplementedInPrivateScript({{method.argument_de
return false;
*result = cppValue;
{% else %}{# void return type #}
- PrivateScriptRunner::runDOMMethod(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
+ PrivateScriptRunner::run(scriptState, "{{cpp_class}}", "{{method.name}}", holder, {{method.arguments | length}}, argv);
if (block.HasCaught())
return false;
{% endif %}

Powered by Google App Engine
This is Rietveld 408576698