src/runtime.cc - Issue 362983004: Harden Runtime_LiveEditCheckAndDropActivations against unsafe args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 362983004: Harden Runtime_LiveEditCheckAndDropActivations against unsafe args. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 0f802515e1fc9ee51b0bd88e8a8c6992502f6ee0..949c6176893c07009a34ae13448f3fa68f798453 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -13503,6 +13503,7 @@ RUNTIME_FUNCTION(Runtime_LiveEditCheckAndDropActivations) {

CONVERT_ARG_HANDLE_CHECKED(JSArray, shared_array, 0);

CONVERT_BOOLEAN_ARG_CHECKED(do_drop, 1);

RUNTIME_ASSERT(shared_array->length()->IsSmi());

+ RUNTIME_ASSERT(shared_array->HasFastElements())

int array_length = Smi::cast(shared_array->length())->value();

for (int i = 0; i < array_length; i++) {

Handle<Object> element =

« no previous file with comments | « src/liveedit.cc ('k') | test/mjsunit/regress/regress-crbug-390925.js » ('j') | no next file with comments »