Issue 362963005: Make ScriptWrappable's destructor empty in oilpan bulids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 362963005: Make ScriptWrappable's destructor empty in oilpan bulids (Closed)

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 5 months ago

Reviewers:
oilpan-reviews, Tom Sepez, jochen (gone - plz use gerrit)

CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make ScriptWrappable's destructor empty in oilpan bulids In Oilpan, we no longer need ScriptWrappable's destructor. This CL makes the destructor empty. I'll completely remove the destructor from oilpan builds in a follow-up CL. See my comments in ScriptWrappable.h for why we can remove each line of the destructor. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177389

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	Source/bindings/core/v8/ScriptWrappable.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/362963005/20001

6 years, 5 months ago (2014-07-02 13:07:28 UTC) #4

Message was sent while issue was closed.

Change committed as 177389

Expand Messages | Collapse Messages