Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 362963002: Add more generator/yield parsing tests (Closed)

Created:
6 years, 5 months ago by wingo
Modified:
6 years, 5 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Add more generator/yield parsing tests R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22155

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix generator syntax in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -27 lines) Patch
M test/cctest/test-parsing.cc View 1 11 chunks +161 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
PTAL :)
6 years, 5 months ago (2014-07-02 10:24:15 UTC) #1
marja
https://codereview.chromium.org/362963002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/362963002/diff/1/test/cctest/test-parsing.cc#newcode1787 test/cctest/test-parsing.cc:1787: "function yield(yield) { yield: yield (yield + yield (0)); ...
6 years, 5 months ago (2014-07-02 11:39:22 UTC) #2
wingo
https://codereview.chromium.org/362963002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/362963002/diff/1/test/cctest/test-parsing.cc#newcode1810 test/cctest/test-parsing.cc:1810: { "\"use strict\"; (function gen* () { (function not_gen() ...
6 years, 5 months ago (2014-07-02 11:42:49 UTC) #3
marja
Ah, I misread the comment. LGTM, I trust you to fix the misplaced * before ...
6 years, 5 months ago (2014-07-02 11:43:57 UTC) #4
wingo
6 years, 5 months ago (2014-07-02 12:27:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698