Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 362923003: Oilpan: insist that CompositeCreators be stack allocated. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: insist that CompositeCreators be stack allocated. And add missing Oilpan (transition) type to the heap allocated MessagePortArray member of Deserializer. R=haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/bindings/core/v8/SerializedScriptValue.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-02 08:24:29 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-02 08:25:47 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-02 08:31:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/362923003/1
6 years, 5 months ago (2014-07-02 08:31:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 09:38:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 09:52:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15029)
6 years, 5 months ago (2014-07-02 09:52:26 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-02 09:54:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/362923003/1
6 years, 5 months ago (2014-07-02 09:56:05 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:12:47 UTC) #10
Message was sent while issue was closed.
Change committed as 177375

Powered by Google App Engine
This is Rietveld 408576698