Changes Windows disk identifiers from GUID to PhysicalDriveN

Changes Windows disk identifiers from GUID to PhysicalDriveN

BUG=384426
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282192

[Drew Haven, 2014-07-02 01:48:18]

See bug for a bug for some extensive comments.  This change just changes the ids
from GUIDs to "//./PhysicalDiskN", where N is the first unused positive integer
at the time the disk is initialized.

[vabr (Chromium), 2014-07-02 08:15:47]

Thanks, Drew, LGTM.

Usually I would expect also a test, but I understand that this hardware-related
code might have other conventions, and I rely on you as the OWNER to do the best
thing.

Cheers,
Vaclav

[Drew Haven, 2014-07-07 19:27:12]

On 2014/07/02 08:15:47, vabr (Chromium) wrote:
> Thanks, Drew, LGTM.
> 
> Usually I would expect also a test, but I understand that this
hardware-related
> code might have other conventions, and I rely on you as the OWNER to do the
best
> thing.
> 
> Cheers,
> Vaclav

Right, the whole RemovableStorageProvider layer is really just a wrapper around
the OS calls, which I have never found a good way to test.  In all our other
tests this is the part we fake so that the tests have known stable data.

[Drew Haven, 2014-07-07 19:27:27]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-07-07 19:28:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/362903002/2

[commit-bot: I haz the power, 2014-07-07 23:05:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/30028)

[commit-bot: I haz the power, 2014-07-07 23:17:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 23:17:45]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Drew Haven, 2014-07-09 21:26:56]

The CQ bit was checked by haven@chromium.org

[commit-bot: I haz the power, 2014-07-09 21:28:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haven@chromium.org/362903002/30001

[commit-bot: I haz the power, 2014-07-10 00:33:34]

Change committed as 282192