Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 362893006: Revert "Reland 22105 "Remove static initializer from isolate"" (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Reland 22105 "Remove static initializer from isolate"" BUG=none TBR=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=22141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M src/isolate.h View 6 chunks +8 lines, -8 lines 0 comments Download
M src/isolate.cc View 6 chunks +28 lines, -10 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/check-static-initializers.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-02 07:43:28 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r22141.
6 years, 5 months ago (2014-07-02 07:44:14 UTC) #2
Yang
6 years, 5 months ago (2014-07-02 07:44:37 UTC) #3
Message was sent while issue was closed.
On 2014/07/02 07:44:14, jochen wrote:
> Committed patchset #1 manually as r22141.

lgtm.

Powered by Google App Engine
This is Rietveld 408576698