Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362843003: NewTabButton should implement MaskedTargeterDelegate (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, sadrul
Project:
chromium
Visibility:
Public.

Description

NewTabButton should implement MaskedTargeterDelegate Define the hit test mask for NewTabButton by implementing MaskedTargeterDelegate instead of overriding View::HasHitTestMask() and View::GetHitTestMaskDeprecated(). BUG=388838 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282185

Patch Set 1 #

Patch Set 2 : rebase against ToT #

Patch Set 3 : re-upload #

Patch Set 4 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -35 lines) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 6 chunks +45 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tdanderson
Scott, can you please take a look?
6 years, 5 months ago (2014-07-04 01:30:22 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-09 19:27:28 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-09 19:33:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/362843003/60001
6 years, 5 months ago (2014-07-09 19:35:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 21:09:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-09 22:37:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/169478)
6 years, 5 months ago (2014-07-09 22:37:49 UTC) #7
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-09 22:50:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/362843003/60001
6 years, 5 months ago (2014-07-09 22:53:03 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-09 23:15:22 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:09:27 UTC) #11
Message was sent while issue was closed. 
Change committed as 282185

Powered by Google App Engine
This is Rietveld 408576698