Update analysis.errors notification to the newest spec.

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.analysis;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 15 matching lines @@
   runReflectiveTests(AnalysisDomainTest);
 
   MockServerChannel serverChannel;
   MemoryResourceProvider resourceProvider;
   AnalysisServer server;
   AnalysisDomainHandler handler;
 
   setUp(() {
     serverChannel = new MockServerChannel();
     resourceProvider = new MemoryResourceProvider();
-    server = new AnalysisServer(
-        serverChannel, resourceProvider, new MockPackageMapProvider(), null);
+    server = new AnalysisServer(serverChannel, resourceProvider,
+        new MockPackageMapProvider(), null);
     server.defaultSdk = new MockSdk();
     handler = new AnalysisDomainHandler(server);
   });
 
   group('notification.errors', testNotificationErrors);
   group('updateContent', testUpdateContent);
   group('setSubscriptions', test_setSubscriptions);
 
   group('AnalysisDomainHandler', () {
     group('setAnalysisRoots', () {
@@ skipping 10 matching lines @@
         // TODO(scheglov) implement
         var response = handler.handleRequest(request);
         expect(response, isResponseFailure('0'));
       });
 
       group('included', () {
         test('new folder', () {
           resourceProvider.newFolder('/project');
           resourceProvider.newFile('/project/pubspec.yaml', 'name: project');
           resourceProvider.newFile('/project/bin/test.dart', 'main() {}');
-          request.setParameter(
-              INCLUDED,
-              ['/project']);
+          request.setParameter(INCLUDED, ['/project']);
           var response = handler.handleRequest(request);
           var serverRef = server;
           expect(response, isResponseSuccess('0'));
           // verify that unit is resolved eventually
           return waitForServerOperationsPerformed(server).then((_) {
-            var unit = serverRef.test_getResolvedCompilationUnit('/project/bin/test.dart');
+            var unit = serverRef.test_getResolvedCompilationUnit(
+                '/project/bin/test.dart');
             expect(unit, isNotNull);
           });
         });
       });
     });
 
     group('setPriorityFiles', () {
       test('invalid', () {
         var request = new Request('0', ANALYSIS_SET_PRIORITY_FILES);
         request.setParameter(FILES, ['/project/lib.dart']);
@@ skipping 26 matching lines @@
 
         setPriorityFiles(['/p1/a.dart', '/p2/b.dart']);
         setPriorityFiles(['/p2/b.dart', '/p2/c.dart']);
         setPriorityFiles([]);
       });
     });
 
     group('updateOptions', () {
       test('invalid', () {
         var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
-        request.setParameter(OPTIONS, {'not-an-option' : true});
+        request.setParameter(OPTIONS, {
+          'not-an-option': true
+        });
         var response = handler.handleRequest(request);
         expect(response, isResponseFailure('0'));
       });
 
       test('valid', () {
         AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
         bool analyzeAngular = !options.analyzeAngular;
         bool enableDeferredLoading = options.enableDeferredLoading;
         var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
-        request.setParameter(
-            OPTIONS,
-            {
-              'analyzeAngular' : analyzeAngular,
-              'enableDeferredLoading': enableDeferredLoading,
-              'enableEnums': false
-            });
+        request.setParameter(OPTIONS, {
+          'analyzeAngular': analyzeAngular,
+          'enableDeferredLoading': enableDeferredLoading,
+          'enableEnums': false
+        });
         var response = handler.handleRequest(request);
         expect(response, isResponseSuccess('0'));
         expect(options.analyzeAngular, equals(analyzeAngular));
         expect(options.enableDeferredLoading, equals(enableDeferredLoading));
       });
     });
 
     test('updateSdks', () {
       var request = new Request('0', ANALYSIS_UPDATE_SDKS);
-      request.setParameter(
-          ADDED,
-          ['/dart/sdk-1.3', '/dart/sdk-1.4']);
-      request.setParameter(
-          REMOVED,
-          ['/dart/sdk-1.2']);
+      request.setParameter(ADDED, ['/dart/sdk-1.3', '/dart/sdk-1.4']);
+      request.setParameter(REMOVED, ['/dart/sdk-1.2']);
       request.setParameter(DEFAULT, '/dart/sdk-1.4');
       var response = handler.handleRequest(request);
       // TODO(scheglov) implement
       expect(response, isNull);
     });
   });
 }
 
 
 class AnalysisError {
-  final String file;
   final String errorCode;
-  final int offset;
-  final int length;
+  final String severity;
+  final String type;
+  final Location location;
   final String message;
   final String correction;
-  AnalysisError(this.file, this.errorCode, this.offset, this.length,
+  AnalysisError(this.errorCode, this.severity, this.type, this.location,
       this.message, this.correction);
 
   @override
   String toString() {
-    return 'NotificationError(file=$file; errorCode=$errorCode; '
-        'offset=$offset; length=$length; message=$message)';
+    return 'AnalysisError(location=$location message=$message); '
+        'errorCode=$errorCode; severity=$separator type=$type';
+  }
+}
+
+
+class Location {
+  final String file;
+  final int offset;
+  final int length;
+  final int startLine;
+  final int startColumn;
+  Location(this.file, this.offset, this.length, this.startLine,
+      this.startColumn);
+
+  @override
+  String toString() {
+    return 'Location(file=$file; offset=$offset; length=$length; '
+        'startLine=$startLine; startColumn=$startColumn)';
   }
 }
 
 
 AnalysisError jsonToAnalysisError(Map<String, Object> json) {
-  return new AnalysisError(
-      json['file'],
-      json['errorCode'],
-      json['offset'],
-      json['length'],
-      json['message'],
-      json['correction']);
+  Map<String, Object> jsonLocation = json[LOCATION];
+  Location location = new Location(jsonLocation[FILE], _getSafeInt(jsonLocation,
+      OFFSET, -1), _getSafeInt(jsonLocation, LENGTH, -1), _getSafeInt(jsonLocation,
+      START_LINE, -1), _getSafeInt(jsonLocation, START_COLUMN, -1));
+  return new AnalysisError(json[ERROR_CODE], json[SEVERITY], json[TYPE], location,
+      json['message'], json['correction']);
 }
 
 
+int _getSafeInt(Map<String, Object> json, String key, int defaultValue) {
+  Object value = json[key];
+  if (value is int) {
+    return value;
+  }
+  return defaultValue;
+}
+
+
 /**
  * A helper to test 'analysis.*' requests.
  */
 class AnalysisTestHelper {
   MockServerChannel serverChannel;
   MemoryResourceProvider resourceProvider;
   AnalysisServer server;
   AnalysisDomainHandler handler;
 
   Map<String, List<String>> analysisSubscriptions = {};
 
   Map<String, List<AnalysisError>> filesErrors = {};
   Map<String, List<Map<String, Object>>> filesHighlights = {};
   Map<String, List<Map<String, Object>>> filesNavigation = {};
 
   String testFile = '/project/bin/test.dart';
   String testCode;
 
   AnalysisTestHelper() {
     serverChannel = new MockServerChannel();
     resourceProvider = new MemoryResourceProvider();
-    server = new AnalysisServer(
-        serverChannel, resourceProvider, new MockPackageMapProvider(), null);
+    server = new AnalysisServer(serverChannel, resourceProvider,
+        new MockPackageMapProvider(), null);
     server.defaultSdk = new MockSdk();
     handler = new AnalysisDomainHandler(server);
     // listen for notifications
-    Stream<Notification> notificationStream = serverChannel.notificationController.stream;
+    Stream<Notification> notificationStream =
+        serverChannel.notificationController.stream;
     notificationStream.listen((Notification notification) {
       if (notification.event == ANALYSIS_ERRORS) {
         String file = notification.getParameter(FILE);
         List<Map<String, Object>> errorMaps = notification.getParameter(ERRORS);
         filesErrors[file] = errorMaps.map(jsonToAnalysisError).toList();
       }
       if (notification.event == ANALYSIS_HIGHLIGHTS) {
         String file = notification.getParameter(FILE);
         filesHighlights[file] = notification.getParameter(REGIONS);
       }
@@ skipping 175 matching lines @@
   setUp(() {
     helper = new AnalysisTestHelper();
   });
 
   test('ParserErrorCode', () {
     helper.createSingleFileProject('library lib');
     return helper.waitForOperationsFinished().then((_) {
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, hasLength(1));
       AnalysisError error = errors[0];
-      expect(error.file, '/project/bin/test.dart');
+      expect(error.location.file, '/project/bin/test.dart');
+      expect(error.location.offset, isPositive);
+      expect(error.location.length, isNonNegative);
       expect(error.errorCode, 'ParserErrorCode.EXPECTED_TOKEN');
-      expect(error.offset, isPositive);
-      expect(error.length, isNonNegative);
+      expect(error.severity, 'ERROR');
+      expect(error.type, 'SYNTACTIC_ERROR');
       expect(error.message, isNotNull);
     });
   });
 
   test('StaticWarningCode', () {
-    helper.createSingleFileProject([
-      'main() {',
-      '  print(unknown);',
-      '}']);
+    helper.createSingleFileProject(['main() {', '  print(unknown);', '}']);
     return helper.waitForOperationsFinished().then((_) {
       List<AnalysisError> errors = helper.getTestErrors();
       expect(errors, hasLength(1));
       AnalysisError error = errors[0];
       expect(error.errorCode, 'StaticWarningCode.UNDEFINED_IDENTIFIER');
     });
   });
 }
 
 
@@ skipping 133 matching lines @@
     }
   }
 
   test_setRoots_packages() {
     // prepare package
     String pkgFile = '/packages/pkgA/libA.dart';
     resourceProvider.newFile(pkgFile, '''
 library lib_a;
 class A {}
 ''');
-    packageMapProvider.packageMap['pkgA'] =
-        [resourceProvider.getResource('/packages/pkgA')];
+    packageMapProvider.packageMap['pkgA'] = [resourceProvider.getResource(
+        '/packages/pkgA')];
     addTestFile('''
 import 'package:pkgA/libA.dart';
 main(A a) {
 }
 ''');
     // create project and wait for analysis
     createProject();
     return waitForTasksFinished().then((_) {
       // if 'package:pkgA/libA.dart' was resolved, then there are no errors
       expect(filesErrors[testFile], isEmpty);
@@ skipping 17 matching lines @@
 ''');
     String pkgDependency = posix.join(projectPath, 'package_dep');
     resourceProvider.newFile(pkgDependency, 'contents');
     packageMapProvider.dependencies.add(pkgDependency);
     // Create project and wait for analysis
     createProject();
     return waitForTasksFinished().then((_) {
       expect(filesErrors[testFile], isNot(isEmpty));
       // Add the package to the package map and tickle the package dependency.
       packageMapProvider.packageMap = {
-          'pkgA': [resourceProvider.getResource('/packages/pkgA')] };
+        'pkgA': [resourceProvider.getResource('/packages/pkgA')]
+      };
       resourceProvider.modifyFile(pkgDependency, 'new contents');
       // Let the server time to notice the file has changed, then let
       // analysis omplete.  There should now be no error.
       return pumpEventQueue().then((_) => waitForTasksFinished()).then((_) {
         expect(filesErrors[testFile], isEmpty);
       });
     });
   }
 }