Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 362773003: [DevTools] Explicitly enable/disable Page.viewportChanged protocol event. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Only issue Page.viewportChanged event when device emulation is enabled. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177378

Patch Set 1 #

Total comments: 2

Patch Set 2 : bound to setDeviceMetricsOverride #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/inspector/InspectorPageAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-01 14:58:34 UTC) #1
pfeldman
https://codereview.chromium.org/362773003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/362773003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js#newcode93 Source/devtools/front_end/ResponsiveDesignView.js:93: WebInspector.resourceTreeModel.setViewportChangedEventEnabled(enabled); Could we reuse existing event for that instead?
6 years, 5 months ago (2014-07-01 15:36:30 UTC) #2
dgozman
PTAL https://codereview.chromium.org/362773003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js File Source/devtools/front_end/ResponsiveDesignView.js (right): https://codereview.chromium.org/362773003/diff/1/Source/devtools/front_end/ResponsiveDesignView.js#newcode93 Source/devtools/front_end/ResponsiveDesignView.js:93: WebInspector.resourceTreeModel.setViewportChangedEventEnabled(enabled); On 2014/07/01 15:36:29, pfeldman wrote: > Could ...
6 years, 5 months ago (2014-07-01 16:26:15 UTC) #3
pfeldman
lgtm
6 years, 5 months ago (2014-07-02 08:55:16 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-02 08:57:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/362773003/20001
6 years, 5 months ago (2014-07-02 08:57:50 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 10:06:32 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 13:19:11 UTC) #8
Message was sent while issue was closed. 
Change committed as 177378

Powered by Google App Engine
This is Rietveld 408576698