Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 362753002: Revert of Update SKP version to 34 (Closed)

Created:
6 years, 5 months ago by borenet
Modified:
6 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Update SKP version to 34 (https://codereview.chromium.org/347303003/) Reason for revert: This removed all bench expectations! Original issue's description: > Update SKP version to 34 > > Automatic commit by the RecreateSKPs bot. > > TBR= > > Committed: https://skia.googlesource.com/skia/+/0808c82e83749c24183af92a43c2e0e69b35d745 TBR= NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/e8e8d02

Patch Set 1 #

Patch Set 2 : Manual upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2332 lines, -1 line) Patch
M SKP_VERSION View 1 1 chunk +1 line, -1 line 0 comments Download
A expectations/bench/bench_expectations_Perf-Android-GalaxyNexus-SGX540-Arm7-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Android-Nexus10-MaliT604-Arm7-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Android-Nexus4-Adreno320-Arm7-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Android-Nexus7-Tegra3-Arm7-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Mac10.8-MacMini4.1-GeForce320M-x86-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Ubuntu12-ShuttleA-GTX660-x86-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Win7-ShuttleA-HD2000-x86-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Win7-ShuttleA-HD2000-x86-Release-ANGLE.txt View 1 1 chunk +63 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Win8-ShuttleA-GTX660-x86-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expectations/bench/bench_expectations_Perf-Win8-ShuttleA-HD7770-x86-Release.txt View 1 1 chunk +252 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
Created Revert of Update SKP version to 34
6 years, 5 months ago (2014-07-01 12:46:41 UTC) #1
borenet
The CQ bit was checked by borenet@google.com
6 years, 5 months ago (2014-07-01 13:33:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/362753002/1
6 years, 5 months ago (2014-07-01 13:34:17 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 13:34:20 UTC) #4
commit-bot: I haz the power
Failed to apply patch for expectations/bench/bench_expectations_Perf-Android-GalaxyNexus-SGX540-Arm7-Release.txt: While running git apply --index -p1; Created missing directory ...
6 years, 5 months ago (2014-07-01 13:34:21 UTC) #5
borenet
6 years, 5 months ago (2014-07-01 13:39:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as re8e8d02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698