Chromium Code Reviews

Unified Diff: src/heap.h

Issue 362723003: Added a promotion queue unit test that test promotion queue memory corruption (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | src/heap.cc » ('j') | src/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.h
diff --git a/src/heap.h b/src/heap.h
index 754b5588e05f89b11c8fffc7d77df82d5d29872a..f113c3ad49917b8dadf8197f96200f2dc16a4ad7 100644
--- a/src/heap.h
+++ b/src/heap.h
@@ -425,6 +425,12 @@ class PromotionQueue {
RelocateQueueHead();
}
+ bool IsBelowPromotionQueue(Address address) {
titzer 2014/07/01 11:58:20 Can you split the condition up into multiple branc
Hannes Payer (out of office) 2014/07/01 16:08:12 Done.
+ return (GetHeadPage() != Page::FromAddress(address) ||
+ NewSpacePage::IsAtStart(reinterpret_cast<Address>(rear_)) ||
+ reinterpret_cast<intptr_t*>(address) <= rear_);
+ }
+
bool is_empty() {
return (front_ == rear_) &&
(emergency_stack_ == NULL || emergency_stack_->length() == 0);
« no previous file with comments | « no previous file | src/heap.cc » ('j') | src/heap.cc » ('J')

Powered by Google App Engine