Added a promotion queue unit test that test promotion queue memory corruption

Added a promotion queue unit test that test promotion queue memory corruption
by semi-space evacuation.

BUG=
R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22134

[titzer, 2014-07-01 11:58:21]

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc#newcode1953
src/heap.cc:1953: ASSERT(!heap->InToSpace(target) ||
Comments here too?

https://codereview.chromium.org/362723003/diff/20001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.h#newcode428
src/heap.h:428: bool IsBelowPromotionQueue(Address address) {
Can you split the condition up into multiple branches and add some comments as
to what each case means? (for future adventurers)

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc...
test/cctest/test-heap.cc:4343: // semi-space pages and take advantage of
fragementation.
I like these comments

[Hannes Payer (out of office), 2014-07-01 16:08:12]

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc#newcode1953
src/heap.cc:1953: ASSERT(!heap->InToSpace(target) ||
On 2014/07/01 11:58:20, titzer wrote:
> Comments here too?

Done.

https://codereview.chromium.org/362723003/diff/20001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.h#newcode428
src/heap.h:428: bool IsBelowPromotionQueue(Address address) {
On 2014/07/01 11:58:20, titzer wrote:
> Can you split the condition up into multiple branches and add some comments as
> to what each case means? (for future adventurers)

Done.

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc...
test/cctest/test-heap.cc:4343: // semi-space pages and take advantage of
fragementation.
On 2014/07/01 11:58:20, titzer wrote:
> I like these comments

I know.

[Hannes Payer (out of office), 2014-07-01 16:08:12]

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.cc#newcode1953
src/heap.cc:1953: ASSERT(!heap->InToSpace(target) ||
On 2014/07/01 11:58:20, titzer wrote:
> Comments here too?

Done.

https://codereview.chromium.org/362723003/diff/20001/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/362723003/diff/20001/src/heap.h#newcode428
src/heap.h:428: bool IsBelowPromotionQueue(Address address) {
On 2014/07/01 11:58:20, titzer wrote:
> Can you split the condition up into multiple branches and add some comments as
> to what each case means? (for future adventurers)

Done.

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/362723003/diff/20001/test/cctest/test-heap.cc...
test/cctest/test-heap.cc:4343: // semi-space pages and take advantage of
fragementation.
On 2014/07/01 11:58:20, titzer wrote:
> I like these comments

I know.

[titzer, 2014-07-01 16:37:19]

lgtm

[Hannes Payer (out of office), 2014-07-01 18:48:27]

Committed patchset #6 manually as r22134 (presubmit successful).