Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 362613002: Implementation of SigninClient::GetSigninScopedDeviceId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes after feedback from Roger. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_manager_factory.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.h
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.h b/chrome/browser/ui/sync/one_click_signin_helper.h
index 6aa15d4111613e1115b7567e08035801d0a4d22b..168a2cc90c22e5602947df3dde2c2f9dd91ee8c1 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.h
+++ b/chrome/browser/ui/sync/one_click_signin_helper.h
@@ -100,7 +100,6 @@ class OneClickSigninHelper
const std::string& email,
const std::string& password,
const std::string& refresh_token,
- const std::string& signin_scoped_device_id,
content::WebContents* web_contents,
bool untrusted_confirmation_required,
signin::Source source,
@@ -114,7 +113,6 @@ class OneClickSigninHelper
std::string email;
std::string password;
std::string refresh_token;
- std::string signin_scoped_device_id;
// Web contents in which the sync setup page should be displayed,
// if necessary. Can be NULL.
@@ -214,7 +212,7 @@ class OneClickSigninHelper
// Handles cross account sign in error. If the supplied |email| does not match
// the last signed in email of the current profile, then Chrome will show a
// confirmation dialog before starting sync. It returns true if there is a
- // cross ccount error, and false otherwise.
+ // cross account error, and false otherwise.
static bool HandleCrossAccountError(
content::WebContents* contents,
const std::string& session_index,
« no previous file with comments | « chrome/browser/signin/signin_manager_factory.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698