Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 362553004: Disable session invalidations on Android with a flag. (Closed)

Created:
6 years, 5 months ago by maxbogue
Modified:
6 years, 5 months ago
Reviewers:
nyquist, Colin Meek
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable session invalidations on Android with a flag. This will allow us to roll the change out gradually using Finch. BUG=385213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283476

Patch Set 1 #

Patch Set 2 : Attempt to fix try errors by reading the flag at run time. #

Patch Set 3 : Try using LibraryLoader.isInitialized() to fix try tests. #

Patch Set 4 : Try checking the ClankSessionNotifications flag at run time. #

Patch Set 5 : getNonInvalidationType() -> isNonInvalidationType() #

Total comments: 2

Patch Set 6 : Remove unnecessary else clause. #

Patch Set 7 : Rename flag to AndroidSessionNotifications. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java View 1 2 3 4 5 6 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
maxbogue
Please review!
6 years, 5 months ago (2014-07-08 22:00:54 UTC) #1
nyquist
how does this work if you first register with the sessions datatype, and then the ...
6 years, 5 months ago (2014-07-09 21:50:19 UTC) #2
maxbogue
On 2014/07/09 21:50:19, nyquist wrote: > how does this work if you first register with ...
6 years, 5 months ago (2014-07-09 22:01:48 UTC) #3
maxbogue
https://codereview.chromium.org/362553004/diff/80001/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java File sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java (right): https://codereview.chromium.org/362553004/diff/80001/sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java#newcode102 sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:102: return mNonInvalidationType; On 2014/07/09 21:50:19, nyquist wrote: > Since ...
6 years, 5 months ago (2014-07-09 22:02:03 UTC) #4
nyquist
meek: PTAL I think you're right in that sync is covered at next startup. I'm ...
6 years, 5 months ago (2014-07-09 23:00:49 UTC) #5
colinmeek
After starting the invalidation client, the InvalidationService should get a #reissueRegistrations call. If the set ...
6 years, 5 months ago (2014-07-10 17:17:19 UTC) #6
maxbogue
On 2014/07/10 17:17:19, colinmeek wrote: > After starting the invalidation client, the InvalidationService should get ...
6 years, 5 months ago (2014-07-11 18:20:51 UTC) #7
colinmeek
The invalidation client periodically verifies that its internal registration state is consistent with the backend ...
6 years, 5 months ago (2014-07-11 19:35:37 UTC) #8
maxbogue
On 2014/07/11 19:35:37, colinmeek wrote: > The invalidation client periodically verifies that its internal registration ...
6 years, 5 months ago (2014-07-11 20:05:06 UTC) #9
nyquist
On 2014/07/11 20:05:06, maxbogue wrote: > On 2014/07/11 19:35:37, colinmeek wrote: > > The invalidation ...
6 years, 5 months ago (2014-07-11 23:24:50 UTC) #10
maxbogue
On 2014/07/11 23:24:50, nyquist wrote: > On 2014/07/11 20:05:06, maxbogue wrote: > > On 2014/07/11 ...
6 years, 5 months ago (2014-07-14 21:10:49 UTC) #11
nyquist
lgtm
6 years, 5 months ago (2014-07-15 18:49:30 UTC) #12
maxbogue
On 2014/07/15 18:49:30, nyquist wrote: > lgtm If I switch the command line flag and ...
6 years, 5 months ago (2014-07-15 19:59:10 UTC) #13
Colin Meek
lgtm
6 years, 5 months ago (2014-07-15 23:34:48 UTC) #14
maxbogue
The CQ bit was checked by maxbogue@chromium.org
6 years, 5 months ago (2014-07-16 00:13:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maxbogue@chromium.org/362553004/120001
6 years, 5 months ago (2014-07-16 00:17:51 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 20:13:51 UTC) #17
Message was sent while issue was closed.
Change committed as 283476

Powered by Google App Engine
This is Rietveld 408576698