Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 362543004: Fix generation of v14 resources (Closed)

Created:
6 years, 5 months ago by cjhopman
Modified:
6 years, 5 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix generation of v14 resources generate_v14_compatible_resources.GenerateV14Resources was deleting and recreating the output directory. process_resources was calling that multiple times and reusing the same output directory (and so it would only actually get v14 resources for the final directory). Instead, callers of GenerateV14Resources should handle deleting/creating the output directory for themselves--this is just generate_v14_compatible_resources.main and process_resources (which was already handling this itself). BUG=383803 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280725

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/android/gyp/generate_v14_compatible_resources.py View 2 chunks +6 lines, -5 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
newt: * https://codereview.chromium.org/362543004/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/362543004/diff/1/build/java_apk.gypi#newcode497 build/java_apk.gypi:497: '--resource-dirs', '<(resource_dir)', did you know that python ...
6 years, 5 months ago (2014-06-30 21:46:10 UTC) #1
newt (away)
lgtm https://codereview.chromium.org/362543004/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/362543004/diff/1/build/java_apk.gypi#newcode497 build/java_apk.gypi:497: '--resource-dirs', '<(resource_dir)', On 2014/06/30 21:46:10, cjhopman wrote: > ...
6 years, 5 months ago (2014-06-30 22:38:08 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 5 months ago (2014-06-30 23:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/362543004/1
6 years, 5 months ago (2014-06-30 23:22:25 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 01:45:08 UTC) #5
Message was sent while issue was closed.
Change committed as 280725

Powered by Google App Engine
This is Rietveld 408576698