Issue 362533002: Make CanPredictNetworkActionsIO take io_data instead of resource_context.

Issue 362533002: Make CanPredictNetworkActionsIO take io_data instead of resource_context. (Closed)

Created:
6 years, 5 months ago by Bence

Modified:
6 years, 5 months ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make CanPredictNetworkActionsIO take io_data instead of resource_context. CanPredictNetworkActionsIO only deals the ProfileIOData of resource_context, not any other properties, and this is not planned to change. Therefore it is more natural to pass it io_data directly. BUG=334602 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280617

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address msg2. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	chrome/browser/net/prediction_options.h	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
	M	chrome/browser/net/prediction_options.cc	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mmenke

LGTM, just two nits. No need for a re-review. https://codereview.chromium.org/362533002/diff/1/chrome/browser/net/prediction_options.h File chrome/browser/net/prediction_options.h (right): https://codereview.chromium.org/362533002/diff/1/chrome/browser/net/prediction_options.h#newcode12 chrome/browser/net/prediction_options.h:12: ...

6 years, 5 months ago (2014-06-30 14:54:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bnc@chromium.org/362533002/20001

6 years, 5 months ago (2014-06-30 16:00:48 UTC) #4

Bence

6 years, 5 months ago (2014-06-30 19:54:26 UTC) #6

Message was sent while issue was closed.

FYI.

https://codereview.chromium.org/362533002/diff/1/chrome/browser/net/predictio...
File chrome/browser/net/prediction_options.h (right):

https://codereview.chromium.org/362533002/diff/1/chrome/browser/net/predictio...
chrome/browser/net/prediction_options.h:12: class ProfileIOData;
On 2014/06/30 14:54:57, mmenke wrote:
> nit:  Alphabetize

Done.

https://codereview.chromium.org/362533002/diff/1/chrome/browser/net/predictio...
chrome/browser/net/prediction_options.h:37: bool
CanPredictNetworkActionsIO(ProfileIOData* io_data);
On 2014/06/30 14:54:57, mmenke wrote:
> optional nit:  Suggest calling this profile_io_data (We also have
> IOThread::Globals, which aren't per-profile, so think the profile is an
> important disambiguator).

Done.

Expand Messages | Collapse Messages