Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: Tools/GardeningServer/scripts/results.js

Issue 362453003: Remove dead code. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/net.js ('k') | Tools/GardeningServer/scripts/results_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/results.js
diff --git a/Tools/GardeningServer/scripts/results.js b/Tools/GardeningServer/scripts/results.js
index 2e59d03492e011134de8af666fde5e53003379d3..937e3ac6d47c67f7e3a44fc19c8d317a6c7eb8ba 100644
--- a/Tools/GardeningServer/scripts/results.js
+++ b/Tools/GardeningServer/scripts/results.js
@@ -50,10 +50,6 @@ var kActualTextSuffix = '-actual.txt';
var kDiffTextSuffix = '-diff.txt';
var kCrashLogSuffix = '-crash-log.txt';
-var kPNGExtension = 'png';
-var kTXTExtension = 'txt';
-var kWAVExtension = 'wav';
-
var kPreferredSuffixOrder = [
kExpectedImageSuffix,
kActualImageSuffix,
@@ -139,28 +135,7 @@ function possibleSuffixListFor(failureTypeList)
return base.uniquifyArray(suffixList);
}
-results.failureTypeToExtensionList = function(failureType)
-{
- switch(failureType) {
- case IMAGE:
- return [kPNGExtension];
- case AUDIO:
- return [kWAVExtension];
- case TEXT:
- return [kTXTExtension];
- case MISSING:
- case IMAGE_TEXT:
- return [kTXTExtension, kPNGExtension];
- default:
- // FIXME: Add support for the rest of the result types.
- // '-expected.html',
- // '-expected-mismatch.html',
- // ... and possibly more.
- return [];
- }
-};
-
-results.failureTypeList = function(failureBlob)
+function failureTypeList(failureBlob)
{
return failureBlob.split(' ');
};
@@ -182,11 +157,6 @@ function resultsSummaryURL(builderName)
return resultsDirectoryURL(builderName) + kResultsName;
}
-function resultsSummaryURLForBuildNumber(builderName, buildNumber)
-{
- return resultsDirectoryURLForBuildNumber(builderName, buildNumber) + kResultsName;
-}
-
var g_resultsCache = new base.AsynchronousCache(function(key) {
return net.jsonp(key);
});
@@ -195,8 +165,8 @@ results.ResultAnalyzer = base.extends(Object, {
init: function(resultNode)
{
this._isUnexpected = resultNode.is_unexpected;
- this._actual = resultNode ? results.failureTypeList(resultNode.actual) : [];
- this._expected = resultNode ? this._addImpliedExpectations(results.failureTypeList(resultNode.expected)) : [];
+ this._actual = resultNode ? failureTypeList(resultNode.actual) : [];
+ this._expected = resultNode ? this._addImpliedExpectations(failureTypeList(resultNode.expected)) : [];
},
_addImpliedExpectations: function(resultsList)
{
@@ -232,12 +202,6 @@ results.ResultAnalyzer = base.extends(Object, {
}
});
-function isExpectedFailure(resultNode)
-{
- var analyzer = new results.ResultAnalyzer(resultNode);
- return !analyzer.hasUnexpectedFailures() && !analyzer.succeeded() && !analyzer.flaky() && !analyzer.wontfix();
-}
-
function isUnexpectedFailure(resultNode)
{
var analyzer = new results.ResultAnalyzer(resultNode);
@@ -249,11 +213,6 @@ function isResultNode(node)
return !!node.actual;
}
-results.expectedFailures = function(resultsTree)
-{
- return base.filterTree(resultsTree.tests, isResultNode, isExpectedFailure);
-};
-
results.unexpectedFailures = function(resultsTree)
{
return base.filterTree(resultsTree.tests, isResultNode, isUnexpectedFailure);
@@ -273,11 +232,6 @@ function resultsByTest(resultsByBuilder, filter)
return resultsByTest;
}
-results.expectedFailuresByTest = function(resultsByBuilder)
-{
- return resultsByTest(resultsByBuilder, results.expectedFailures);
-};
-
results.unexpectedFailuresByTest = function(resultsByBuilder)
{
return resultsByTest(resultsByBuilder, results.unexpectedFailures);
@@ -288,7 +242,7 @@ results.failureInfoForTestAndBuilder = function(resultsByTest, testName, builder
var failureInfoForTest = {
'testName': testName,
'builderName': builderName,
- 'failureTypeList': results.failureTypeList(resultsByTest[testName][builderName].actual),
+ 'failureTypeList': failureTypeList(resultsByTest[testName][builderName].actual),
};
return failureInfoForTest;
« no previous file with comments | « Tools/GardeningServer/scripts/net.js ('k') | Tools/GardeningServer/scripts/results_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698