src/images/SkImageDecoder_ktx.cpp - Issue 362413005: Check pixelRef before attempting to ktx encode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder_ktx.cpp

Issue 362413005: Check pixelRef before attempting to ktx encode. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder_ktx.cpp

diff --git a/src/images/SkImageDecoder_ktx.cpp b/src/images/SkImageDecoder_ktx.cpp

index c2606321c2516c74d543dbc32afcc285e89398b5..058ab7264695cb8c6cfb7274f2d0a87646850ee6 100644

--- a/src/images/SkImageDecoder_ktx.cpp

+++ b/src/images/SkImageDecoder_ktx.cpp

@@ -209,6 +209,9 @@ private:

};

bool SkKTXImageEncoder::onEncode(SkWStream* stream, const SkBitmap& bitmap, int) {

+ if (!bitmap.pixelRef()) {

+ return false;

+ }

SkAutoDataUnref data(bitmap.pixelRef()->refEncodedData());

// Is this even encoded data?

« no previous file with comments | « no previous file | no next file » | no next file with comments »