Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 362413005: Check pixelRef before attempting to ktx encode. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
krajcevski
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Check pixelRef before attempting to ktx encode. If there is no pixelRef, do not attempt to dereference it. This was caught running on Android, where we don't have the resources folder (tracked in b/14406768). We fail to decode anything, and then attempt to encode an SkBitmap without a pixelRef. Committed: https://skia.googlesource.com/skia/+/c2dcf4a4a56027fd9129c1f170b79fb1af63011f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/images/SkImageDecoder_ktx.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
6 years, 5 months ago (2014-07-02 21:45:43 UTC) #1
krajcevski
On 2014/07/02 21:45:43, scroggo wrote: lgtm
6 years, 5 months ago (2014-07-02 21:48:28 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-02 21:48:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/362413005/1
6 years, 5 months ago (2014-07-02 21:49:16 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 22:00:10 UTC) #5
Message was sent while issue was closed.
Change committed as c2dcf4a4a56027fd9129c1f170b79fb1af63011f

Powered by Google App Engine
This is Rietveld 408576698