Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 362353004: Set cloned_session_storage_namespace_id on error in RenderMessageFilter::OnCreateWindow(). (Closed)

Created:
6 years, 5 months ago by Tom Sepez
Modified:
6 years, 5 months ago
Reviewers:
piman, inferno
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Set cloned_session_storage_namespace_id on error in RenderMessageFilter::OnCreateWindow(). This prevents a MSAN warning. BUG=390973 R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
piman, please review. Details are in the bug. Thanks.
6 years, 5 months ago (2014-07-02 17:46:53 UTC) #1
piman
LGTM. I think it would be useful to make sure all message replies are always ...
6 years, 5 months ago (2014-07-07 18:06:59 UTC) #2
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 5 months ago (2014-07-09 22:16:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/362353004/1
6 years, 5 months ago (2014-07-09 22:17:30 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:57:53 UTC) #5
Message was sent while issue was closed.
Change committed as 282203

Powered by Google App Engine
This is Rietveld 408576698