chrome/browser/extensions/extension_system_impl.cc - Issue 362343006: Fix dangerous pointer use in UserScriptMaster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_system_impl.cc

Issue 362343006: Fix dangerous pointer use in UserScriptMaster (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_system_impl.cc

diff --git a/chrome/browser/extensions/extension_system_impl.cc b/chrome/browser/extensions/extension_system_impl.cc

index 3b065df66ff0c45b1c37deabfb80f6c93ac02077..8e853085a61f02dd8832c245a020d400157fcb1f 100644

--- a/chrome/browser/extensions/extension_system_impl.cc

+++ b/chrome/browser/extensions/extension_system_impl.cc

@@ -291,7 +291,7 @@ void ExtensionSystemImpl::Shared::Init(bool extensions_enabled) {

bool allow_noisy_errors = !command_line->HasSwitch(switches::kNoErrorDialogs);

ExtensionErrorReporter::Init(allow_noisy_errors);

- user_script_master_ = new UserScriptMaster(profile_);

+ user_script_master_.reset(new UserScriptMaster(profile_));

// ExtensionService depends on RuntimeData.

runtime_data_.reset(new RuntimeData(ExtensionRegistry::Get(profile_)));