chrome/browser/extensions/convert_user_script.cc - Issue 362343006: Fix dangerous pointer use in UserScriptMaster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/convert_user_script.cc

Issue 362343006: Fix dangerous pointer use in UserScriptMaster (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/convert_user_script.cc

diff --git a/chrome/browser/extensions/convert_user_script.cc b/chrome/browser/extensions/convert_user_script.cc

index 1a7d48f1c2e4b903f0bcf2a31d4e01423ea2d3ef..a7a7c29e1122164477dc5cf59bc6e45c2762b2bc 100644

--- a/chrome/browser/extensions/convert_user_script.cc

+++ b/chrome/browser/extensions/convert_user_script.cc

@@ -45,8 +45,7 @@ scoped_refptr<Extension> ConvertUserScriptToExtension(

}

UserScript script;

- if (!UserScriptMaster::ScriptReloader::ParseMetadataHeader(content,

- &script)) {

+ if (!UserScriptMaster::ParseMetadataHeader(content, &script)) {

*error = base::ASCIIToUTF16("Invalid script header.");

return NULL;

}