Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 362333002: [SVG] Promote PathOpsSVGClipping to experimental. (Closed)

Created:
6 years, 5 months ago by f(malita)
Modified:
6 years, 5 months ago
Reviewers:
pdr., Stephen Chennney, fs
CC:
blink-reviews, caryclark, reed1
Project:
blink
Visibility:
Public.

Description

[SVG] Promote PathOpsSVGClipping to experimental. Re-enabling pathops-based SVG clipping after numerous Skia updates. A handful of pixel tests require minor rebaselines. BUG=263911 R=fs@opera.com, schenney@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177411

Patch Set 1 #

Patch Set 2 : Mark 14 layout tests for rebaseline. #

Patch Set 3 : Rebased TestExpectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
Layout test diffs can be inspected here: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/14475/layout-test-results/results.html
6 years, 5 months ago (2014-07-02 14:24:48 UTC) #1
fs
LGTM (not platform-owner)
6 years, 5 months ago (2014-07-02 14:41:57 UTC) #2
Stephen Chennney
lgtm
6 years, 5 months ago (2014-07-02 16:33:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/362333002/40001
6 years, 5 months ago (2014-07-02 16:34:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-02 17:43:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-02 18:25:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15116)
6 years, 5 months ago (2014-07-02 18:26:01 UTC) #7
f(malita)
6 years, 5 months ago (2014-07-02 19:00:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r177411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698